Towards vectorized convolution (second PR) #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
approved these changes
Oct 31, 2024
| } | ||
|
|
||
| // Parse Ext op. | ||
| ParseResult ExtOp::parse(OpAsmParser &parser, OperationState &result) { |
There was a problem hiding this comment.
Does this really need cpp parse/print functions? It would be nice to just use tablegen. Same for ShiftOp below. No hard objections though as it's copy/paste from mlir-aie aievec.
There was a problem hiding this comment.
( @jsetoain if you have an opinion )
There was a problem hiding this comment.
Jorn is correct, none of these need custom parsers/printers, and they've ended up the way they are for non-technical reasons. It's a matter of finding the time to clean up. I'll create an issue to keep track of this.
Edit: Here it is, issue #1894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a copy of MLIR op definitions from mlir-aie. These ops are needed to lower
transfer_readwith insufficient alignment correctly. In a future PR, the ops added in this PR will be used to lowertransfer_read.