[SplitLogicalObjectFifos] Add support for dma tranposed on the target side #850
+220
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhang93
requested review from
MaheshRavishankar,
nirvedhmeshram,
Abhishek-Varma and
jtuyls
as code owners
Abhishek-Varma
requested changes
Oct 21, 2024
| scf.forall (%arg4, %arg5) in (2, 2) { | ||
| %2 = affine.apply #map(%arg5) | ||
| %3 = affine.apply #map(%arg4) | ||
| %4 = amdaie.dma_cpy_nd(%0[0, 0, 0, 0] [2, 32, 2, 32] [2048, 32, 1024, 1], %1[%3, %2] [64, 64] [128, 1]) : (!amdaie.logicalobjectfifo<memref<2x2x32x32xi32, 1 : i32>>, !amdaie.logicalobjectfifo<memref<128x128xi32>>) |
There was a problem hiding this comment.
I'd prefer adding an analysis between L2 ObjectFifo's shape <2x2x32x32> and the sizes involved in L2 as target [2, 32, 2, 32] to infer whether a transpose has taken place instead of using a pass flag for the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #812 added support to transpose dma dimensions on the target side for control code optimization. However, this new dma addressing wasn't supported in
SplitLogicalObjectFifosForConnectionReusepass.This PR keeps the original logic and most of the original codes while adding the support for the new dma format.