Skip to content

Commit

Permalink
Merge pull request #252 from noborus/homebrew-arm
Browse files Browse the repository at this point in the history
Added a note for Mac arm version
  • Loading branch information
noborus authored Nov 2, 2023
2 parents 0e3b994 + bb74db8 commit dd50b25
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
7 changes: 0 additions & 7 deletions .github/trdsql.template.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@ class Trdsql < Formula
version "{{ version }}"

on_macos do
if Hardware::CPU.arm?
url "{{ DARWIN_ARM64_URL }}"
sha256 "{{ DARWIN_ARM64_SHA256 }}"
def install
bin.install "trdsql"
end
end
if Hardware::CPU.intel?
url "{{ DARWIN_AMD64_URL }}"
sha256 "{{ DARWIN_AMD64_SHA256 }}"
Expand Down
6 changes: 3 additions & 3 deletions .github/update-homebrew-tap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ get_url_and_sha256() {
echo "$url $sha256"
}

darwin_arm64=$(get_url_and_sha256 "dist/trdsql_${VERSION}_darwin_arm64.zip")
darwin_arm64_url=$(echo "${darwin_arm64% *}" | sed 's/\//\\\//g')
darwin_arm64_sha256=${darwin_arm64#* }
#darwin_arm64=$(get_url_and_sha256 "dist/trdsql_${VERSION}_darwin_arm64.zip")
#darwin_arm64_url=$(echo "${darwin_arm64% *}" | sed 's/\//\\\//g')
#darwin_arm64_sha256=${darwin_arm64#* }

darwin_amd64=$(get_url_and_sha256 "dist/trdsql_${VERSION}_darwin_amd64.zip")
darwin_amd64_url=$(echo "${darwin_amd64% *}" | sed 's/\//\\\//g')
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ Download binary from the [releases](https://github.com/noborus/trdsql/releases)
brew install noborus/tap/trdsql
```

**Note**: For ARM Macs, it is recommended to use [go get](#go-get) instead of Homebrew: [issue#197](https://github.com/noborus/trdsql/issues/197)

### 1.4. <a name='macports'></a>MacPorts

```console
Expand Down

0 comments on commit dd50b25

Please sign in to comment.