Merge pull request #249 from noborus/fix-maxbulk

Fixed INSERT failure when there are many columns
noborus · Nov 1, 2023 · 1ac533b · 1ac533b
2 parents 4f87009 + a3e3bec
commit 1ac533b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/database.go b/database.go
@@ -204,7 +204,11 @@ func (db *DB) insertImport(ctx context.Context, table *importTable, reader Reade
 	var stmt *sql.Stmt
 	defer db.stmtClose(stmt)
 
-	table.maxCap = (db.maxBulk / len(table.row)) * len(table.row)
+	if len(table.row) > db.maxBulk {
+		table.maxCap = len(table.row)
+	} else {
+		table.maxCap = (db.maxBulk / len(table.row)) * len(table.row)
+	}
 	bulk := make([]interface{}, 0, table.maxCap)
 
 	preRows := reader.PreReadRow()

diff --git a/database_connect.go b/database_connect.go
@@ -37,7 +37,7 @@ func Connect(driver, dsn string) (*DB, error) {
 	switch driver {
 	case "sqlite3", "sqlite3_ext", "sqlite":
 		db.quote = "`"
-		db.maxBulk = 500
+		db.maxBulk = 1000
 	case "mysql":
 		db.quote = "`"
 		db.maxBulk = 1000

diff --git a/database_connect_cgo.go b/database_connect_cgo.go
@@ -45,7 +45,7 @@ func Connect(driver, dsn string) (*DB, error) {
 	switch driver {
 	case "sqlite3", "sqlite3_ext", "sqlite":
 		db.quote = "`"
-		db.maxBulk = 500
+		db.maxBulk = 10000
 	case "mysql":
 		db.quote = "`"
 		db.maxBulk = 1000