Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend SLO status by most recent process status [PC-14514] #570

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

mkaras-nobl9
Copy link
Contributor

@mkaras-nobl9 mkaras-nobl9 commented Oct 14, 2024

Motivation

Adds new SLO process statuses to the status field.

Summary

before:

apiVersion: n9/v1alpha
kind: SLO
...
status:
  timeTravel:
    source: user
    startTime: 2024-07-22T08:10:38Z
    status: completed
    triggeredBy: 00udqsfk2d3Oe8ljW4x6
    unit: Day
    value: 30.0
  targetSlo:
      timeTravelStatus:
        startTime: 2024-07-21T08:10:38Z
        status: completed
        triggeredBy: 00u6axxaftHIMOizO4x7
        unit: Day
        value: 30.0
  updatedAt: 2024-10-03T07:52:25Z

after:

  apiVersion: n9/v1alpha
  kind: SLO
  ...
  status:
    compositeSlo:
      startTime: 2024-10-14T03:49:06Z
      status: queued
      triggeredBy: 00u6axxaftHIMOizO4x7
      unit: Hour
      value: 9.0
    errorBudgetAdjustment:
      startTime: 2024-10-14T01:57:42Z
      status: queued
      triggeredBy: 00u6axxaftHIMOizO4x7
      unit: Hour
      value: 10.0
    replay:
      startTime: 2024-10-13T11:20:32Z
      status: queued
      triggeredBy: 00u6axxaftHIMOizO4x7
      unit: Day
      value: 1.0
    targetSlo:
      replay:
        startTime: 2024-07-21T08:10:38Z
        status: completed
        triggeredBy: 00u6axxaftHIMOizO4x7
        unit: Day
        value: 30.0
    updatedAt: 2024-10-14T11:20:31Z

Related changes

https://github.com/nobl9/n9/pull/15672

Breaking changes

SLO kind:

  • The status.timeTravel field has been renamed to status.replay.
  • The status.timeTravel.source field has been removed.
  • The status.targetSlo.timeTravelStatus field has been renamed to status.targetSlo.replay.

Release Notes

Added new fields for SLO kind status, which reflect the current state of the last process for the given type - replay, errorBudgetAdjustment, compositeSlo.

@mkaras-nobl9 mkaras-nobl9 merged commit eb9041d into main Oct 16, 2024
5 checks passed
@mkaras-nobl9 mkaras-nobl9 deleted the PC-14514-slo-status-processes branch October 16, 2024 11:18
@n9-machine-user n9-machine-user added the breaking-change We're breaking the API label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change We're breaking the API enhancement New feature or request go minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants