Fix issue in xcvrd - If port is missing in Config DB, don't need to handle changes in TRANSCEIVER_INFO table #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaOrMlnx
force-pushed
the
port_not_exist_xcvrd_fix
branch
from
aa55410 to
8cdc32f
Compare
… table is changed" This reverts commit 8cdc32f.
noaOrMlnx
force-pushed
the
port_not_exist_xcvrd_fix
branch
from
aa0135a to
7f9e669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When port is missing in CONFIG DB, there is no need to enter "on_port_update_event()" function, and update some tables.
In case this code is missing, TRANSCIEVER_INFO table will be updated when switch starts (because cable is connected), and will try to update some other tables in redis.
Since the port does not exist in config Db, tables are not there as well and xcvrd will crash trying to search for them.
How Has This Been Tested?
On a switch with CMIS host mgmt enabled, with missing ports from Config DB.
Additional Information (Optional)