-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Application] add README for LLaMA application @open sesame 11/07 16:01 #2787
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2787. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
cibot: @baek2sm, The last line of a text file must have a newline character. Please append a new line at the end of the line in Applications/LLaMA/README.md. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411061611350.27023911476135-9f5730dd949f541d0b653a19548ba491f5d54c45/report/misspelling_result.txt. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411061612270.75429797172546-648433647144b7e6380794d500b571aa0c3fcd90/report/misspelling_result.txt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baek2sm, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
if change vocab & merges, they need to changeencoder or tokenizer too
Resolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Applications/LLaMA/README.md
Outdated
- [Getting Started](../../docs/getting-started.md) | ||
- [how-to-run-example-android](../../docs/how-to-run-example-android.md) | ||
|
||
To run your own LLaMA model, you need to prepare three additional files in application build directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "in application build directory" mean inside the jni directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djeong20 It means the jni directory, but it is not the one where source codes reside.
rather, this directory is generated as a result of building user's application.
I have modified the expression to "inside the application build directory". Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- remove vocab.json and merges.txt files since each llama version utilizes distinct vocab.json and merges.txt files. - add README.md file for LLaMA application. Signed-off-by: Seungbaek Hong <[email protected]>
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071442390.69266891479492-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071449320.62098789215088-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt. |
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071500400.38160395622253-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baek2sm, 💯 All CI checkers are successfully verified. Thanks.
INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071600470.48532509803772-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baek2sm, 💯 All CI checkers are successfully verified. Thanks.
Signed-off-by: Seungbaek Hong [email protected]