Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Application] add README for LLaMA application @open sesame 11/07 16:01 #2787

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

baek2sm
Copy link
Contributor

@baek2sm baek2sm commented Nov 6, 2024

  • remove vocab.json and merges.txt files since each llama version utilizes distinct vocab.json and merges.txt files.
  • add README.md file for LLaMA application.

Signed-off-by: Seungbaek Hong [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 6, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2787. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 6, 2024

:octocat: cibot: @baek2sm, The last line of a text file must have a newline character. Please append a new line at the end of the line in Applications/LLaMA/README.md.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 6, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411061611350.27023911476135-9f5730dd949f541d0b653a19548ba491f5d54c45/report/misspelling_result.txt.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 6, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411061612270.75429797172546-648433647144b7e6380794d500b571aa0c3fcd90/report/misspelling_result.txt.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
if change vocab & merges, they need to changeencoder or tokenizer too

Resolve

Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- [Getting Started](../../docs/getting-started.md)
- [how-to-run-example-android](../../docs/how-to-run-example-android.md)

To run your own LLaMA model, you need to prepare three additional files in application build directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "in application build directory" mean inside the jni directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djeong20 It means the jni directory, but it is not the one where source codes reside.
rather, this directory is generated as a result of building user's application.
I have modified the expression to "inside the application build directory". Thanks!

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- remove vocab.json and merges.txt files since each llama version utilizes distinct vocab.json and merges.txt files.
- add README.md file for LLaMA application.

Signed-off-by: Seungbaek Hong <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 7, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071442390.69266891479492-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt.

@baek2sm baek2sm changed the title [Application] add README for LLaMA application [Application] add README for LLaMA application @open sesame 11/07 14:50 Nov 7, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 7, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071449320.62098789215088-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt.

@baek2sm baek2sm changed the title [Application] add README for LLaMA application @open sesame 11/07 14:50 [Application] add README for LLaMA application @open sesame 11/07 15:01 Nov 7, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 7, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071500400.38160395622253-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

@baek2sm baek2sm changed the title [Application] add README for LLaMA application @open sesame 11/07 15:01 [Application] add README for LLaMA application @open sesame 11/07 16:01 Nov 7, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 7, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2787-202411071600470.48532509803772-1de18b0c0c1117c1a0eabfa60effc36bf45d0d2c/report/misspelling_result.txt.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

@jijoongmoon jijoongmoon merged commit d0ed9b4 into nnstreamer:main Nov 8, 2024
42 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants