Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unittest] Add constant DerivativeLossLayer unittest #2766

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

DonghakPark
Copy link
Member

Currently, there is a layersemantics in the NNTrainer Unittest that verifies the behavior of the losslayer but it does not include the case for the constant DerivativeLossLayer.

By simply filling in the parameters and passing them over, we can perform unit tests on basic operations so I added this feature.

commit : [Unittest] Add constant DerivativeLossLayer unittest

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Currently, there is a layersemantics in the NNTrainer Unittest that verifies the behavior of the losslayer
but it does not include the case for the constant DerivativeLossLayer.

By simply filling in the parameters and passing them over, we can perform unit tests on basic operations
so I added this feature.

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 22, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2766. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonghakPark, 💯 All CI checkers are successfully verified. Thanks.

Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit b088845 into nnstreamer:main Oct 25, 2024
41 checks passed
@DonghakPark DonghakPark deleted the Add_unittest_2410 branch October 30, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants