Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU/OpenCL] Adding map/unmap feature for buffer @open sesame 10/29 21:51 #2688

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[GPU/OpenCL] Adding map/unmap feature for buffer @open sesame 10/29 21:51 #2688

merged 1 commit into from
Oct 29, 2024

Conversation

s-debadri
Copy link
Contributor

@s-debadri s-debadri commented Jul 30, 2024 •
edited
Loading

Changes in this PR:

  • Modified opencl::Buffer constructor to use CL_MEM_USE_HOST_PTR to use host memory from GPU.
  • Loaded APIs for clEnqueueMapBuffer and clEnqueueUnmapMemObject OpenCL functions to map/unmap opencl::Buffer to host address space.
  • Added required functions in opencl::Buffer and opencl::CommandQueueManager classes to manage mapping and unmapping from host address.

Purpose of these changes is to make use of host memory to reduce the copying of data to and from GPU.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Debadri Samaddar [email protected]

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 30, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2688. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 30, 2024

:octocat: cibot: @s-debadri, nntrainer/opencl/opencl_buffer.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

taos-ci
taos-ci approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-debadri, 💯 All CI checkers are successfully verified. Thanks.

EunjuYang
EunjuYang approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon
Copy link
Collaborator

please check CI as in https://github.com/nnstreamer/nntrainer/actions/runs/10161997426

djeong20
djeong20 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jijoongmoon jijoongmoon changed the title [GPU/OpenCL] Adding map/unmap feature for buffer [GPU/OpenCL] Adding map/unmap feature for buffer @open sesame 10/04 17:02 Oct 4, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 4, 2024

:octocat: cibot: @s-debadri, nntrainer/opencl/opencl_buffer.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 4, 2024

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2688-202410041721460.45381903648376-b4ee2cdf8e037e0317868365a78ad537ac68741a/.

@jijoongmoon jijoongmoon changed the title [GPU/OpenCL] Adding map/unmap feature for buffer @open sesame 10/04 17:02 [GPU/OpenCL] Adding map/unmap feature for buffer @open sesame 10/29 21:51 Oct 29, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 29, 2024

:octocat: cibot: @s-debadri, nntrainer/opencl/opencl_buffer.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

@taos-ci
Copy link
Collaborator

taos-ci commented Oct 29, 2024

:octocat: cibot: @s-debadri, nntrainer/opencl/opencl_buffer.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

taos-ci
taos-ci approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-debadri, 💯 All CI checkers are successfully verified. Thanks.

@s-debadri
[GPU/Optimization] Adding map/unmap feature for buffer
a87e4fb 
Implementing map and unmap buffer options to re-use host memory

Signed-off-by: Debadri Samaddar <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Oct 29, 2024

:octocat: cibot: @s-debadri, nntrainer/opencl/opencl_buffer.cpp includes bug(s). Please fix incorrect coding constructs in your commit before entering a review process.

taos-ci
taos-ci approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-debadri, 💯 All CI checkers are successfully verified. Thanks.

jijoongmoon
jijoongmoon approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 3f8409b into nnstreamer:main Oct 29, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeong20 djeong20 djeong20 approved these changes

@taos-ci taos-ci taos-ci approved these changes

@jijoongmoon jijoongmoon jijoongmoon approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@lhs8928 lhs8928 Awaiting requested review from lhs8928 lhs8928 is a code owner

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@skykongkong8 skykongkong8 Awaiting requested review from skykongkong8 skykongkong8 is a code owner

Assignees
No one assigned
Labels
BUILD/CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s-debadri @taos-ci @jijoongmoon @EunjuYang @djeong20