Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main branch error after merging #2704 #2715

Closed
djeong20 opened this issue Aug 23, 2024 · 2 comments · Fixed by #2717
Closed

Main branch error after merging #2704 #2715

djeong20 opened this issue Aug 23, 2024 · 2 comments · Fixed by #2717
Assignees
Labels
bug Something isn't working

Comments

@djeong20
Copy link
Contributor

The NNTrainer main branch has an error after merging #2704.
The build error was resolved by #2714, but issues with failing unit tests remain. The details are as follows.

The output from the failed tests:

23/41 unittest_nntrainer_tensor_fp16          FAIL     0.37 s (exit status 1)
...
[  PASSED  ] 125 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] nntrainer_Tensor.dot_06_p
[  FAILED  ] nntrainer_Tensor.dot_transpose_p

 2 FAILED TESTS
-------

27/41 unittest_layers                         FAIL     0.37 s (killed by signal 11 SIGSEGV)
...
[----------] 3 tests from FullyConnected16/LayerGoldenTest
[ RUN      ] FullyConnected16/LayerGoldenTest.run/0
 ** On entry to SGEMM  parameter number 13 had an illegal value
 ** On entry to SGEMM  parameter number 10 had an illegal value
../test/unittest/layers/layers_golden_tests.cpp:236: Failure
Expected: ((cos_sim)) >= ((1 - cos_sim_range)), actual: 0.766846 vs 0.99999
../test/unittest/layers/layers_golden_tests.cpp:241: Failure
Expected: ((mean_squared_error)) <= ((mse_range)), actual: 19.4233 vs 0.015
../test/unittest/layers/layers_golden_tests.cpp:296: Failure
Value of: compare_percentage_tensors(tensor, answer, match_percentage, skip_cos_sim)
  Actual: false
Expected: true
outputs at 0
../test/unittest/layers/layers_golden_tests.cpp:241: Failure
Expected: ((mean_squared_error)) <= ((mse_range)), actual: 772.4 vs 0.05
../test/unittest/layers/layers_golden_tests.cpp:241: Failure
Expected: ((mean_squared_error)) <= ((mse_range)), actual: 1.97871 vs 0.03
-------

PTAL @skykongkong8

@djeong20 djeong20 added the bug Something isn't working label Aug 23, 2024
@taos-ci
Copy link
Collaborator

taos-ci commented Aug 23, 2024

:octocat: cibot: Thank you for posting issue #2715. The person in charge will reply soon.

@djeong20
Copy link
Contributor Author

Additionally, current GitHub Action meson_test (ubuntu-20.04, -Denable-fp16=true) is not functioning correctly. It is built and run without enabling fp16. (fp16 unit tests cannot be found)

DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 23, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 23, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 23, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 23, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 23, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 23, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
@skykongkong8 skykongkong8 linked a pull request Aug 26, 2024 that will close this issue
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 27, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 28, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Aug 28, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Sep 2, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
jijoongmoon pushed a commit that referenced this issue Sep 6, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- #2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
DonghakPark added a commit to DonghakPark/nntrainer that referenced this issue Oct 8, 2024
Fix build bug
- Currently, there is a bug in the matrix used in CI where the first Meson build runs successfully but subsequent builds fail due to the presence of a 'build' folder. I would like to fix this issue.
- Before running the Meson build, ensure that any existing folders named 'build' are deleted.
- fix gcc version to 13

Resolves:
- nnstreamer#2715

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
Co-authored-by: hyeonseok <[email protected]>
Co-authored-by: Donghyeon Jeong <[email protected]>
(cherry picked from commit b6fdba0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants