Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a proper policy on install-able binaries #56

Open
wooksong opened this issue Aug 2, 2019 · 2 comments
Open

Need a proper policy on install-able binaries #56

wooksong opened this issue Aug 2, 2019 · 2 comments

Comments

@wooksong
Copy link
Member

wooksong commented Aug 2, 2019

After building and installing nnstreamer-example in my local machine, I got the following files under ${prefix}/bin:

-rw-r--r--    get-model-image-classification-tflite.sh
-rw-r--r--    get-model-object-detection-tflite.sh
-rw-r--r--    get-model-object-detection-tf.sh
-rw-r--r--    get-model-speech-command.sh
-rwxr-xr-x    gst-launch-object-detection-tflite.sh
-rwxr-xr-x    gst-launch-object-detection-tf.sh
-rwxr-xr-x    libnnscustom_speech_command_tflite.so
-rwxr-xr-x    nnstreamer_example_cam
-rwxr-xr-x    nnstreamer_example_decoder_image_labelling
-rwxr-xr-x    nnstreamer_example_filter_performance_profile
-rwxr-xr-x    nnstreamer_example_image_classification_caffe2
-rwxr-xr-x    nnstreamer_example_image_classification_tflite
-rw-r--r--    nnstreamer_example_image_classification_tflite.py
-rwxr-xr-x    nnstreamer_example_object_detection_tf
-rwxr-xr-x    nnstreamer_example_object_detection_tflite
-rwxr-xr-x    nnstreamer_example_speech_command_tflite
-rwxr-xr-x    nnstreamer_example_two_tensor_stream
-rwxr-xr-x    nnstreamer_sink_example
-rwxr-xr-x    nnstreamer_sink_example_play

As we can see, some files have execution permission and others do not. In addition, naming conventions are mixed. They do not looks intuitive.

In my opinion, it would be better to formulate a proper policy that affects

  • naming conventions
  • install locations of binaries/get-model-* scripts/wget-ed model files
  • permissions for the scripts.
@taos-ci
Copy link
Collaborator

taos-ci commented Aug 2, 2019

:octocat: cibot: Thank you for posting issue #56. The person in charge will reply soon.

@myungjoo
Copy link
Member

myungjoo commented Aug 5, 2019

What about /usr/lib/nnstreamer/example/${example binaries}?
We already install subplugins at /usr/lib/nnstreamer/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants