-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seen_by_guid property to feeds for dynamic link feeds #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StormPooper
commented
Oct 29, 2022
StormPooper
commented
Oct 29, 2022
StormPooper
commented
Oct 29, 2022
StormPooper
commented
Oct 29, 2022
Looks perfect on the first glance! Thanks for your contribution! I will test and probably merge in the next days. |
No worries, thanks for considering it. Let me know if you want me to change anything 👍 |
Thanks again for your contribution! I had a chance to have a second look now and I will merge it directly. |
nning
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently moved from Jackett to Prowlarr and noticed that some torrents were being re-added to my download client despite entries being added to my
seen_file
. After some investigation. I realized it was because Prowlarr "proxies" the download link to go through itself rather than directly to the result and in doing so generates a unique URL. The problem was that this URL is not static and changes for each request, so my seen_file was never matching on the URL and bloating with hashes for the same torrent over and over.To fix this, I've added an option called
seen_by_guid
to thefeed
object. This, as the name implies, will use theguid
on the feed item, which should be consistent. This defaults tofalse
to prevent invalidating existing seen files and falls back to the link if there is no guid element in the result.I've also added tests for the areas I've impacted to try and ensure I didn't break anything. All tests pass and it seems to be behaving correctly in Docker with and without
seen_by_guid
from my manual testing.Let me know if you'd like any changes, and thank you for creating transmission-rss.