Show DNS Resolver in NNS

[rhrazdil]

Signed-off-by: Radim Hrazdil [email protected]

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What this PR does / why we need it:

DNS Resolver is not included in NodeNetworkState, adding types to marshal/unmarshal
DNS data and include it in the NNS as well.

Special notes for your reviewer:

Release note:

Show dns-resolver in NodeNetworkState

[creydr]

could we use the firstSecondaryNic variable here instead of using eth1 directly? Because the e2e tests in OCP use another NIC name for the first secondary (from FIRST_SECONDARY_NIC env var)

[rhrazdil]

Hey, this is just a unit test and the names don't really matter

[creydr]

Ah sorry. My fault

[qinqon]

So this was introduced at #709, maybe we don't need that anymore.

[rhrazdil]

So this was introduced at #709, maybe we don't need that anymore.

#709 introduces structures for routes and interfaces, but not the dns-resolver.

[qinqon]

So this was introduced at #709, maybe we don't need that anymore.

#709 introduces structures for routes and interfaces, but not the dns-resolver.

Looks like nmstate is going to move to yaml 1.2 at the rust implementation, so when we integrate with it we can revert the PR.

[qinqon]

/retest

Something is fishy at CI maybe it's time to use podman.

creating container buildx_buildkit_kubernetes-nmstate-builder0
#1 22.62 error: failed to list workers: Unavailable: connection error: desc = "transport: error while dialing: dial unix /run/buildkit/buildkitd.sock: connect: no such file or directory"
#1 creating container buildx_buildkit_kubernetes-nmstate-builder0 22.2s done
#1 

[yboaron]

Thanks for adding this fix.

Checked it in my env - looks OK.

It is worth mentioning that (at least based on what I get in my env) , it seems that nns.dnsresolver equals to /var/run/NetworkManager/resolv.conf and not /etc/resolv.conf

[yboaron]

/lgtm

[qinqon]

Thanks for adding this fix.

Checked it in my env - looks OK.

It is worth mentioning that (at least based on what I get in my env) , it seems that nns.dnsresolver equals to /var/run/NetworkManager/resolv.conf and not /etc/resolv.conf

That depends on the NetworkManager configuration, you can configure if you want it to manage /etc/resolv.conf or not, for example at OCP we have NetworkManager not manager /etc/resolv.conf but at the same time we have the prepend dispatcher script.

From an kubernetes-nmstate perspectives safest is to just check NNS.

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qinqon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment