-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control plane, Assign Priority class to pods #777
Conversation
Add system-node-critical to nmstate-handler, since this pod should run on each node, Add system-cluster-critical to nmstate-webhook and to nmstate-cert-manager pods, since those pods aren't bound to a specific node, yet those are important control plane pods. This will make the control plane less sensitive to preemption than user workloads. Signed-off-by: Or Shoval <[email protected]>
Hi @oshoval. Thanks for your PR. I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@qinqon need ok to test please and review if possible |
/ok-to-test |
I don't think the failure is due to this PR /retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.47 |
@oshoval: only nmstate org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add
system-node-critical
tonmstate-handler
,since this pod should run on each node,
Add
system-cluster-critical
tonmstate-webhook
and to
nmstate-cert-manager
pods,since those pods aren't bound to a specific node,
yet those are important control plane pods.
This will make the control plane less sensitive to preemption
than user workloads.
Signed-off-by: Or Shoval [email protected]