state, filter: Treat numeric-only iface names #708
Conversation
When processing the filtering of the interfaces status, the interfaces with names that include only numeric characters are interpreted as float64. In order to (partially) support such interfaces, make sure to detect them and avoid their filtering. I.E. these interfaces cannot be filtered-out. Note: This solution is partial due to the improper interpretation of special numeric (only) names such as (123.0 and 0xff). These will wrongly get interpreted as 123 and 255. Signed-off-by: Edward Haas <[email protected]>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@EdDev: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I do not really like this solution, it looks like a workaround. Trying something else... |
kubevirt-bot
added
the
do-not-merge/work-in-progress
|
See #709 for a better alternative to this one. |
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
When processing the filtering of the interfaces status, the interfaces
with names that include only numeric characters are interpreted as
float64.
In order to (partially) support such interfaces, make sure to detect them
and avoid their filtering. I.E. these interfaces cannot be filtered-out.
Note: This solution is partial due to the improper interpretation of
special numeric (only) names such as (123.0 and 0xff). These will
wrongly get interpreted as 123 and 255.
Special notes for your reviewer:
Release note: