Refactor/adapt runtime to new relationships api #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
jkoenig134
previously approved these changes
Apr 24, 2024
tnotheis
previously approved these changes
Apr 24, 2024
jkoenig134
previously approved these changes
Apr 24, 2024
jkoenig134
previously approved these changes
Apr 24, 2024
jkoenig134
previously approved these changes
Apr 24, 2024
jkoenig134
approved these changes
Apr 24, 2024
stnmtz
approved these changes
Apr 24, 2024
Milena-Czierlinski
added a commit
that referenced
this pull request
May 24, 2024
* Feature/Add ThirdPartyOwnedRelationshipAttributeSuccession (#74) * feat: add thirdPartyOwnedRelationshipAttributeSuccession * fix: remove todos * Feature/AttributeSuccessionAcceptResponseItem for ReadAttributeRequestItemProcessor (#80) * feat: add is{Predecessor,Successor}Of * feat: add AttributeSuccessionAcceptResponseItem * feat: adjust ReadAttributeRequestItemProcessor * test: AttributeSuccessionAcceptResponseItem for ReadAttributeRequestItemProcessor * feat: add thirdPartyOwnedRelationshipAttributeSuccession * fix: succession in ReadAttributeRequestItemProcessor * test: succession in ReadAttributeRequestItemProcessor * feat: omit check for RepositoryAttribute in getSharedVersionsOfRepositoryAttribute * fix: ownSharedThirdPartyAttributeSuccession * feat: allow applyIncomingResponseItem to return events * fix: make iql tests independent * test: returned event applying incoming ResponseItem * feat: integrate comments * feat: add AttributeSuccessionAcceptResponseItem to DataViewExpander * feat: integrate comments * fix: adjust renamed functions in tests * feat: integrate comments * feat: correct test names * feat: combine isA{Predecessor,Successor}Of to a single function * feat: add TODO comment for renaming getSharedVersionsOfRepositoryAttribute --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Feature/AttributeSuccessionAcceptResponseItem for ProposeAttributeRequestItemProcessor (#101) * feat: add AttributeSuccessionAcceptResponseItem for ProposeAttributeRequestItemProcessor * test: AcceptSuccessionResponseItem in ProposeAttributeRequestItemDVO * feat: integrate comments * feat: integrate comments --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * feat: add AttributeAlreadySharedAcceptResponseItem (#108) * Refactor/adapt runtime to new relationships api (#90) * chore: adapt accept, reject, revoke runtime use cases * chore: change relationship classes * chore: adapt transmission types * chore: rename transmission request/response types * fix: relationships backbone response type * chore: adapt RelationshipsController * chore: adapt ExternalEventsProcessor * chore: adapt the relationship use cases * chore: adapt request response type * chore: adapt completing incoming requests * refactor: content type names * feat: get relationship with audit logs, fix types * chore: adapt outgoing request controller and use cases * chore: adapt relationship (change) dtos * chore: adapt request module * chore: adapt index file * refactor: auditLog is transport relationship member * chore: adapt relationship getter use cases * chore: rename use cases * chore: adapt transport validation * chore: adapt schemas and further renaming * chore: rename relation creation request content file * refactor: renaming types * chore: adapt request consumption tests * refactor: rename content to creation content in sendRelationship * fix: relationship creation request type name * chore: adapt final consumption and transport tests * chore: adapt runtime tests * fix: adapt changes in transport tests * chore: adapt the new external event processor * chore: use correct backbone version * fix: adapt to backbone signature * fix: await promise * fix: update status with relationship * refactor: move audit log to relationship cache * refactor: merge the relationship event handlers * fix: relationship controller flows * refactor: relationship types * fix: audit log deserializer * fix: relationship event payload * fix: get correct creation/acceptance content * fix: only decrypt relationship if secrets available * fix: don't use sync result in a test * chore: remove comments / debug code * fix: transport tests, sort audit log * fix: consumption tests, request controller type * refactor: remove auditLog flag in useCases * fix: assorted fixes * chore: update app-runtime * fix: exports * refactor: massively simplify DTO creation * fix: app runtime tests * fix: import * fix: mandatory audit log * fix: adapt relationship dto/dvo, remove null checks * refactor/fix: add audit log to test factory, remove redundant method * fix: de-duplicate functions * fix: redo old behaviour * fix: casing * fix: update event behaviour * fix: re-add some tests * fix: make peer an address again * refactor: mandatory payload in put * feat: add the relationship changes to the relationship dto * chore: add validation to outoing request controller * refactor: relationshipCreationContent instead of CreationRequestContent * refactor/fix: auditLog to relationshipAuditLog, add createdByDevice * refactor: simplify RelationshipMapper * chore: remove unused runtime error * fix: re-add check, remove throw * fix: add createdByDevice to relationship DTO * refactor: cleaner function call * test: add old relationship change tests; test for creation content * fix: add createdByDevice to audit log method * fix: wrong type annotations * fix: condition in createRequestFromTemplateResponse * fix: add createdBDevice to TestObjectFactory audit logs * refactor: rename auditLog file * refactor: cosmetic changes * refactor: correct audit log in test object factory * fix: add oldStatus * refactor: remove empty acceptanceContents * refactor: request/response to creation-/acceptanceContent * chore: adapt backbone return types, type check * fix: correctly use types * refactor: no type extension in backboneGetRelationships * fix: catch undefined creation content * refactor: fail fast undefined creation content * fix: this was supposed to be the previous commit * refactor: add relationship prefix to audit log * refactor: rename relationship event processor * refactor: change checks, use JSONWrapper for creation content * refactor: split audit log class * fix: update import * refactor: acceptanceContent -> creationResponseContent * refactor: combine events * fix: naming * chore: bump backbone * chore: add admin ui to compose * fix: naming * chore: naming * fix: Relationships * fix: re-add import * fix: update types and errors * chore: bump backbone * fix: add enum validators * chore: any is always nullable * fix: pass creation content * fix: throw error again * chore: remove unused content * fix: make publicCreationResponseContentCrypto required * chore: update validate annotation --------- Co-authored-by: Julian König <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * Feature/Rename getSharedVersionsOfAttribute (#109) * feat: rename getSharedVersionsOfAttribute * chore: remove todo * refactor: rename variables * feat: integrate comments * feat: re-add deprecated getSharedVersionsOfRepositoryAttribute --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * fix: allow for slower tests to succeed * fix: use correct statuses * chore: undo v5 changes * chore: version bump --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Magnus Kuhn <[email protected]> Co-authored-by: Julian König <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.