Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry processing password protected references for wrong passwords #384

Merged
merged 15 commits into from
Jan 9, 2025
Merged

Retry processing password protected references for wrong passwords #384

merged 15 commits into from
Jan 9, 2025

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Jan 8, 2025 •
edited
Loading

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@jkoenig134 jkoenig134 added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Jan 8, 2025
@jkoenig134 jkoenig134 marked this pull request as draft January 8, 2025 16:37
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/app-runtime/src/AppStringProcessor.ts 74.57% 15 Missing ⚠️
Files with missing lines Coverage Δ
...ages/app-runtime/src/extensibility/ui/IUIBridge.ts 100.00% <100.00%> (ø)
packages/app-runtime/src/AppStringProcessor.ts 73.61% <74.57%> (-2.25%) ⬇️

@jkoenig134 jkoenig134 marked this pull request as ready for review January 9, 2025 07:18
@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Jan 9, 2025
@jkoenig134 jkoenig134 enabled auto-merge (squash) January 9, 2025 13:15
@jkoenig134 jkoenig134 merged commit f83c0ea into main Jan 9, 2025
18 checks passed
@jkoenig134 jkoenig134 deleted the retry-processing-password-protected-references-for-wrong-passwords branch January 9, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@britsta britsta Awaiting requested review from britsta

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkoenig134 @britsta @Milena-Czierlinski