Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug log for SynchronizedCollection in CI runs for database writes with outdated data #376

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Dec 20, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@sebbi08 sebbi08 added the chore Some routine work like updating dependencies label Dec 20, 2024
@sebbi08 sebbi08 requested a review from jkoenig134 December 20, 2024 07:32
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ansport/src/modules/sync/SynchronizedCollection.ts 41.17% 10 Missing ⚠️
Files with missing lines Coverage Δ
...ansport/src/modules/sync/SynchronizedCollection.ts 36.03% <41.17%> (+0.42%) ⬆️

@jkoenig134 jkoenig134 changed the title Add log in debug mode for db write with wrong data Add debug log for SynchronizedCollection in CI runs for database writes with outdated data Dec 20, 2024
@sebbi08 sebbi08 merged commit 8a079be into main Dec 20, 2024
19 checks passed
@sebbi08 sebbi08 deleted the feature/log_potential_race_condition branch December 20, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Some routine work like updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants