Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Tokens for password protection #362

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Query Tokens for password protection #362

merged 5 commits into from
Dec 13, 2024

Conversation

Magnus-Kuhn
Copy link
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@Magnus-Kuhn Magnus-Kuhn changed the title Query Tokens for password-protection Query Tokens for password protection Dec 10, 2024
@Magnus-Kuhn Magnus-Kuhn added the enhancement New feature or request label Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
...runtime/src/useCases/transport/tokens/GetTokens.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review December 10, 2024 15:20
@Magnus-Kuhn Magnus-Kuhn requested review from jkoenig134 and britsta and removed request for jkoenig134 December 10, 2024 15:21
jkoenig134
jkoenig134 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Magnus-Kuhn Magnus-Kuhn merged commit 59d5579 into main Dec 13, 2024
19 checks passed
@Magnus-Kuhn Magnus-Kuhn deleted the query-password-protected-tokens branch December 13, 2024 12:26
@Magnus-Kuhn Magnus-Kuhn mentioned this pull request Dec 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@britsta britsta Awaiting requested review from britsta

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Magnus-Kuhn @jkoenig134