-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CreateRepositoryAttribute error messages #338
Merged
Magnus-Kuhn
merged 41 commits into
main
from
fix-create-repository-attribute-error-message
Jan 14, 2025
Merged
Improve CreateRepositoryAttribute error messages #338
Magnus-Kuhn
merged 41 commits into
main
from
fix-create-repository-attribute-error-message
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magnus-Kuhn
added
wip
Work in Progress (blocks mergify from auto update the branch)
bug
Something isn't working
labels
Nov 21, 2024
Codecov ReportAttention: Patch coverage is
|
Magnus-Kuhn
changed the title
[Demo] Don't validate contents of CreateRepositoryAttributeUseCase with ajv
[Demo] Don't validate attribute contents in CreateRepositoryAttributeUseCase with ajv
Nov 21, 2024
jkoenig134
reviewed
Nov 26, 2024
packages/runtime/src/useCases/consumption/attributes/CreateRepositoryAttribute.ts
Outdated
Show resolved
Hide resolved
Magnus-Kuhn
changed the title
[Demo] Don't validate attribute contents in CreateRepositoryAttributeUseCase with ajv
Improve CreateRepositoryAttribute error messages
Dec 4, 2024
…://github.com/nmshd/runtime into fix-create-repository-attribute-error-message
Magnus-Kuhn
removed
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Dec 9, 2024
Magnus-Kuhn
requested review from
sebbi08,
jkoenig134,
britsta and
Milena-Czierlinski
December 9, 2024 13:59
britsta
reviewed
Dec 9, 2024
packages/runtime/src/useCases/consumption/attributes/CreateRepositoryAttribute.ts
Outdated
Show resolved
Hide resolved
…://github.com/nmshd/runtime into fix-create-repository-attribute-error-message
jkoenig134
changed the title
Improve CreateRepositoryAttribute error messages
[POC, WIP] Improve CreateRepositoryAttribute error messages
Dec 16, 2024
jkoenig134
added
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Dec 16, 2024
Magnus-Kuhn
removed
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Jan 14, 2025
Magnus-Kuhn
changed the title
[POC, WIP] Improve CreateRepositoryAttribute error messages
Improve CreateRepositoryAttribute error messages
Jan 14, 2025
jkoenig134
reviewed
Jan 14, 2025
packages/runtime/src/types/ajv/CreateRepositoryAttributeRequest.ts
Outdated
Show resolved
Hide resolved
…://github.com/nmshd/runtime into fix-create-repository-attribute-error-message
jkoenig134
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Validates attribute contents in the CreateRepositoryAttribute use case with serval instead of the ajv schema validator. Includes added tests with the resulting error messages when validations fail. It's not perfect (you can have additional properties and the errors of complex attributes are also unclear).
It's not clear that this approach is more promising than attempting to improve the ajv usage.