Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove template from relationship #301

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

jkoenig134
Copy link
Member

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@jkoenig134 jkoenig134 added breaking-change A breaking change refactoring Refactoring of code wip Work in Progress (blocks mergify from auto update the branch) labels Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/runtime/src/modules/RequestModule.ts 76.92% 3 Missing ⚠️
.../modules/relationships/local/CachedRelationship.ts 75.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
packages/runtime/src/dataViews/DataViewExpander.ts 58.82% <100.00%> (-0.07%) ⬇️
...ges/runtime/src/types/transport/RelationshipDTO.ts 100.00% <100.00%> (ø)
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
...eCases/transport/relationships/GetRelationships.ts 100.00% <100.00%> (ø)
...ases/transport/relationships/RelationshipMapper.ts 91.83% <100.00%> (-0.17%) ⬇️
...ionshipTemplates/RelationshipTemplateController.ts 74.02% <100.00%> (-0.08%) ⬇️
...c/modules/relationships/RelationshipsController.ts 85.88% <100.00%> (+0.17%) ⬆️
...rt/src/modules/relationships/local/Relationship.ts 95.08% <100.00%> (-0.04%) ⬇️
packages/runtime/src/modules/RequestModule.ts 57.06% <76.92%> (+0.37%) ⬆️
.../modules/relationships/local/CachedRelationship.ts 93.75% <75.00%> (-6.25%) ⬇️

@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 23, 2024
@jkoenig134 jkoenig134 requested a review from Copilot November 18, 2024 14:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 19 changed files in this pull request and generated 4 suggestions.

Files not reviewed (14)
  • packages/runtime/src/useCases/common/Schemas.ts: Evaluated as low risk
  • packages/transport/test/modules/relationshipTemplates/RelationshipTemplateController.test.ts: Evaluated as low risk
  • packages/runtime/test/consumption/requests.test.ts: Evaluated as low risk
  • packages/transport/test/modules/relationships/decomposition.test.ts: Evaluated as low risk
  • packages/transport/src/modules/relationshipTemplates/RelationshipTemplateController.ts: Evaluated as low risk
  • packages/runtime/test/dataViews/RelationshipDVO.test.ts: Evaluated as low risk
  • packages/transport/test/modules/relationships/RelationshipsController.test.ts: Evaluated as low risk
  • packages/transport/src/modules/relationships/local/Relationship.ts: Evaluated as low risk
  • packages/transport/test/end2end/End2End.test.ts: Evaluated as low risk
  • packages/transport/src/modules/relationships/RelationshipsController.ts: Evaluated as low risk
  • packages/runtime/test/lib/testUtils.ts: Evaluated as low risk
  • packages/runtime/src/useCases/transport/relationships/GetRelationships.ts: Evaluated as low risk
  • packages/runtime/test/transport/relationships.test.ts: Evaluated as low risk
  • packages/runtime/src/types/transport/RelationshipDTO.ts: Evaluated as low risk

@jkoenig134 jkoenig134 added the wip Work in Progress (blocks mergify from auto update the branch) label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A breaking change refactoring Refactoring of code wip Work in Progress (blocks mergify from auto update the branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant