Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GetDeviceOnboardingTokenUseCase to CreateDeviceOnboardingTokenUseCase #289

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Dec 18, 2024

Readiness checklist

  • I ensured that the PR title is good enough.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

Renaming of the GetDeviceOnboardingTokenUseCase in the documentation based on the renaming of the use case in the Runtime (nmshd/runtime#373). Previously, the CreateDeviceOnboardingTokenUseCase in the Runtime was sometimes misleadingly referred to as GetDeviceOnboardingTokenUseCase.

@britsta britsta added wip Work in Progress (blocks mergify from auto update the branch) refactoring Refactoring of code labels Dec 18, 2024
@britsta britsta removed the wip Work in Progress (blocks mergify from auto update the branch) label Dec 18, 2024
@britsta britsta marked this pull request as ready for review December 18, 2024 16:03
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@britsta britsta merged commit 9f4682a into main Dec 18, 2024
6 checks passed
@britsta britsta deleted the refactor/rename-getdeviceonboardingtoken-to-createdeviceonboardingtoken branch December 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants