Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description for password protection of RelationshipTemplates and Tokens #287

Merged
merged 18 commits into from
Dec 19, 2024
Merged

Add description for password protection of RelationshipTemplates and Tokens #287

merged 18 commits into from
Dec 19, 2024

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Dec 16, 2024

Describe the feature of password protection for RelationshipTemplates and Tokens.

@britsta britsta added enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch) labels Dec 16, 2024
@britsta britsta removed the wip Work in Progress (blocks mergify from auto update the branch) label Dec 17, 2024
@britsta britsta marked this pull request as ready for review December 17, 2024 17:59
jkoenig134
jkoenig134 previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Milena-Czierlinski PTAL!

jkoenig134
jkoenig134 previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - again :)

Milena-Czierlinski
Milena-Czierlinski reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forIdentity and passwordProtection are missing as parameters of the use cases Query RelationshipTemplates/Tokens.

_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/error-codes.md Show resolved Hide resolved
_docs_use-cases/use-case-transport-create-own-relationshiptemplate.md Show resolved Hide resolved
_docs_use-cases/use-case-transport-create-token-for-own-relationshiptemplate.md Outdated Show resolved Hide resolved
_docs_use-cases/use-case-transport-get-device-onboarding-token.md Outdated Show resolved Hide resolved
_docs_use-cases/use-case-transport-get-or-load-file.md Outdated Show resolved Hide resolved
_docs_use-cases/use-case-transport-get-or-load-file.md Outdated Show resolved Hide resolved
@britsta
Merge branch 'main' of https://github.com/nmshd/documentation into fe…
bfb6c50 
…ature/password-protection-of-relationshiptemplates-and-tokens
@britsta
Copy link
Contributor Author

britsta commented Dec 19, 2024

forIdentity and passwordProtection are missing as parameters of the use cases Query RelationshipTemplates/Tokens.

Good catch, seems like somebody has used the Schema.ts trick. 😉 I must have missed a PR and will add the parameters to the getters.

Milena-Czierlinski
Milena-Czierlinski reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing. :)

_docs_integrate/establish-relationships.md Outdated Show resolved Hide resolved
@britsta britsta merged commit a0d6873 into main Dec 19, 2024
6 checks passed
@britsta britsta deleted the feature/password-protection-of-relationshiptemplates-and-tokens branch December 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@jkoenig134 jkoenig134 jkoenig134 left review comments

@tnotheis tnotheis Awaiting requested review from tnotheis tnotheis is a code owner

@stnmtz stnmtz Awaiting requested review from stnmtz stnmtz is a code owner

@Magnus-Kuhn Magnus-Kuhn Awaiting requested review from Magnus-Kuhn

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@britsta @jkoenig134 @Magnus-Kuhn @Milena-Czierlinski