-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications can be sent in case of terminated Relationships #286
Merged
britsta
merged 8 commits into
main
from
feature/notifications-can-be-sent-in-case-of-terminated-relationships
Dec 16, 2024
Merged
Notifications can be sent in case of terminated Relationships #286
britsta
merged 8 commits into
main
from
feature/notifications-can-be-sent-in-case-of-terminated-relationships
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britsta
added
enhancement
New feature or request
wip
Work in Progress (blocks mergify from auto update the branch)
labels
Dec 12, 2024
britsta
commented
Dec 12, 2024
britsta
commented
Dec 12, 2024
britsta
removed
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Dec 12, 2024
britsta
requested review from
tnotheis,
jkoenig134 and
stnmtz
as code owners
December 12, 2024 14:17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny details, the rest looks good to me.
Milena-Czierlinski
approved these changes
Dec 16, 2024
britsta
deleted the
feature/notifications-can-be-sent-in-case-of-terminated-relationships
branch
December 16, 2024 15:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to queue Notifications if they are sent while the Relationship was terminated. These can be received and processed after the reactivation of the Relationship.
On the fly, I fixed two broken links and added the currently missing
peerIdentity
property of the RelationshipDTO to the Data Model Overview.