Format address as property of Identity
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I don't like the idea of talking about the Identities Address as only a property b/c its more. For places we really talking about the property (e.g. for copy pasting it to a payload) I'm totally with you, it's just the generalization here that bothers me. |
I understand exactly what you mean (would have been the alternative variant I would have offered to merge) and adjust the passages accordingly. |
jkoenig134
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addressis often a property of an enmeshed Identity and should be formatted accordingly in that cases. In most cases it should at least be written in lowercase (except for sentence beginnings or titles). If it is not the propertyaddressof an Identity that is referred to, but the concept of the enmeshed Address, it is a proper name and should still be capitalized and written unformatted.