Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Add description of Identity deletion and effects of peer deletion on Relationships #274

Merged
merged 60 commits into from
Dec 12, 2024
Merged

Feature/Add description of Identity deletion and effects of peer deletion on Relationships #274

merged 60 commits into from
Dec 12, 2024

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Oct 22, 2024 •
edited
Loading

Can only be merged once PR nmshd/runtime#286 has been merged.

@britsta britsta added the enhancement New feature or request label Oct 22, 2024
britsta added 13 commits October 22, 2024 13:39
@britsta
chore: ensure redirection of prerelease version of Identity deletion …
b5b5085 
…scenario
@britsta
chore: remove prerelease marker
55a8b3f
@britsta
feat: first restructuring and expansion of the prerelease version
2966895
@britsta
feat: mention get methods of IdentityDeletionProcesses
e5e87ac
@britsta
feat: insert links to scenario and use case in data model overview
ab30a4c
@britsta
fix: formatting of non-existent parameters of use case
abbe826
@britsta
feat: link to scenario within getters of IdentityDeletionProcess use …
31f2a7a 
…cases
@britsta
feat: add details to initiate IdentityDeletionProcess use case
e1d08ed
@britsta
feat: add details to approve IdentityDeletionProcess scenario
52d3532
@britsta
feat: add details to reject IdentityDeletionProcess use case
6680cca
@britsta
feat: add details to cancel IdentityDeletionProcess use case
0190ba6
@britsta
refactor: grammatical sentence structure
0d21577
@britsta
chore: include warning that use cases are not yet exposed to Integrators
bc42e29
@britsta britsta changed the title Feature/Add Identity deletion scenario Feature/Add Identity deletion scenario and description of the effects of peer deletion on Relationships Oct 23, 2024
@britsta britsta changed the title Feature/Add Identity deletion scenario and description of the effects of peer deletion on Relationships Feature/Add description of Identity deletion and effects of peer deletion on Relationships Oct 23, 2024
@britsta britsta added the wip Work in Progress (blocks mergify from auto update the branch) label Oct 23, 2024
@britsta britsta requested a review from stnmtz as a code owner December 3, 2024 17:11
jkoenig134
jkoenig134 reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. @Milena-Czierlinski PTAL.

jkoenig134
jkoenig134 previously approved these changes Dec 6, 2024
View reviewed changes
Milena-Czierlinski
Milena-Czierlinski reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for my review @britsta ;)

_data/navigation.yml Outdated Show resolved Hide resolved
_docs_integrate/connector-events.md Show resolved Hide resolved
_docs_integrate/connector-events.md Show resolved Hide resolved
_docs_integrate/connector-events.md Show resolved Hide resolved
_docs_integrate/connector-events.md Outdated Show resolved Hide resolved
_docs_integrate/connector-events.md Outdated Show resolved Hide resolved
Milena-Czierlinski
Milena-Czierlinski reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP

_docs_integrate/data-model-overview.md Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_integrate/data-model-overview.md Show resolved Hide resolved
_docs_integrate/data-model-overview.md Show resolved Hide resolved
_docs_integrate/error-codes.md Outdated Show resolved Hide resolved
_docs_use-cases/use-case-transport-approve-identitydeletionprocess.md Show resolved Hide resolved
_docs_use-cases/use-case-transport-cancel-identitydeletionprocess.md Outdated Show resolved Hide resolved
_docs_use-cases/use-case-transport-get-active-identitydeletionprocess.md Outdated Show resolved Hide resolved
Milena-Czierlinski
Milena-Czierlinski reviewed Dec 9, 2024
View reviewed changes
_docs_integrate/data-model-overview.md Outdated Show resolved Hide resolved
_docs_use-cases/use-case-transport-cancel-identitydeletionprocess.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
_docs_integrate/delete-identities.md Outdated Show resolved Hide resolved
@Milena-Czierlinski
Copy link
Contributor

@britsta LGTM apart from the Backbone Admin UI stuff. :)

@britsta britsta merged commit 236ef3c into main Dec 12, 2024
5 checks passed
@britsta britsta deleted the feature/add-identity-deletion-scenario branch December 12, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

@jkoenig134 jkoenig134 jkoenig134 left review comments

@tnotheis tnotheis Awaiting requested review from tnotheis tnotheis is a code owner

@stnmtz stnmtz Awaiting requested review from stnmtz stnmtz is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@britsta @Milena-Czierlinski @jkoenig134