Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rework integration example #166

Merged
merged 22 commits into from
Feb 5, 2024

Conversation

Milena-Czierlinski
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski commented Nov 2, 2023

No description provided.

@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review November 2, 2023 09:38
@Milena-Czierlinski
Copy link
Contributor Author

Since we discussed not to change the JSON payloads to tables and leave the rapidocs, which is the main part of this PR, should I close this PR, such that we can start from scratch wanting to improve the Integration Example and such that it doesn't block other PRs?

@jkoenig134
Copy link
Member

I don't think this blocks anything. Just assume that it isn't here :D

@vinzlange
Copy link
Contributor

I don't think this blocks anything. Just assume that it isn't here :D

Somehow it blocks the new excel update script, because of the _include structure. Or becomes faulty if the new script is used

@jkoenig134
Copy link
Member

yeah, it will get some merge conflicts, but this is ok. should be easy to resolve.

jkoenig134
jkoenig134 previously approved these changes Feb 5, 2024
@Milena-Czierlinski Milena-Czierlinski merged commit f8704b1 into main Feb 5, 2024
4 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the feature/rework-integration-example branch February 5, 2024 10:30
Milena-Czierlinski added a commit that referenced this pull request May 8, 2024
* fix: update internal links

(cherry picked from commit 4b8f5d0)

* feat: rework create a relationship template, validate and create QR code

(cherry picked from commit 68a5dbd)

* feat: rework accept relationship request, sending and receiving messages

(cherry picked from commit a9d66a8)

* feat: add (commented) links to (future) pages

(cherry picked from commit e201449)

* feat: integration example create attribute

(cherry picked from commit 24fcaa5)

* feat: integration example create attribute

(cherry picked from commit 7de1628)

* feat: put todos in comments, rework create an attribute

(cherry picked from commit ec52658)

* fix: omit version 2 of enmeshed App, add @ to type

(cherry picked from commit 1eb1aff)

* fix: use point-notation in tables

(cherry picked from commit 7608392)

* fix: remove dependent link temporarily

* fix: small text adjustments

* feat: be more precise about payload's content

* chore: generate links

* fix: correct link

* chore: put JSONs, rapidocs back in

* feat: consistent spelling for RelationshipTemplate, Request and Response

* feat: some rephrasing

* feat: small adjustments to payloads

* feat: add more links

---------

Co-authored-by: Britta Stallknecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants