Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
This PR fixes multiple issues with server sent events:
did:
part should represent a URL scheme likehttp:
and fails, because it doesn't support this scheme. See 2ed3e96 for the corresponding commit.PushService
, it is now required to add ASP.NET Identity to the service collection. See bceae43AddAuthorization
withAddAuthorizationBuilder
. Before that, a call to the/api/v1/sse
route returned a 302 (a redirect to the auth endpoint). See 64d63cc.OperationCancelledException
in order to prevent it from being logged (this caused a lot of noise before). See 5e8b2f9.SseController.Subscribe
method. Before it threw an exception in case of a cancelled request, because it tried to returnOk
even though there was no response stream to write to (because the request was cancelled). See 3d47ac7.