-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility for a device to find out whether its identity was deleted #949
Merged
tnotheis
merged 37 commits into
main
from
possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
Dec 2, 2024
Merged
Possibility for a device to find out whether its identity was deleted #949
tnotheis
merged 37 commits into
main
from
possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter finished deletion
…-its-identity-was-deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 29 changed files in this pull request and generated 1 suggestion.
Files not reviewed (15)
- Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Challenges/POST.feature: Language not supported
- Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Identities/IsDeleted/GET.feature: Language not supported
- Modules/Devices/src/Devices.Application/Identities/Queries/IsIdentityOfUserDeleted/Handler.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Application/Infrastructure/Persistence/Repository/IIdentitiesRepository.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Application/Identities/Queries/IsIdentityOfUserDeleted/Validator.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Application/Identities/Queries/IsIdentityOfUserDeleted/IsIdentityOfUserDeletedQuery.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Application/Identities/Commands/HandleCompletedDeletionProcess/Handler.cs: Evaluated as low risk
- Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/ChallengesStepDefinitions.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Application/DTOs/IdentityDeletionProcessDetailsDTO.cs: Evaluated as low risk
- Applications/ConsumerApi/src/DevicesDbContextSeeder.cs: Evaluated as low risk
- Applications/IdentityDeletionJobs/src/Job.IdentityDeletion/Workers/ActualDeletionWorker.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Application/Identities/Queries/GetDeletionProcessesAuditLogs/Handler.cs: Evaluated as low risk
- BuildingBlocks/src/BuildingBlocks.SDK/Endpoints/Common/EndpointClient.cs: Evaluated as low risk
- Modules/Devices/src/Devices.Domain/Entities/Identities/IdentityDeletionProcessAuditLogEntry.cs: Evaluated as low risk
- Modules/Devices/src/Devices.ConsumerApi/Controllers/IdentitiesController.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
Modules/Devices/src/Devices.Application/Users/Commands/SeedTestUsers/Handler.cs:26
- The use of [1, 1, 1, 1, 1] for the identity address and key is incorrect. These should be byte arrays, not lists. Replace [1, 1, 1, 1, 1] with new byte[] { 1, 1, 1, 1, 1 }.
var identityA = Identity.CreateTestIdentity(IdentityAddress.Create([1, 1, 1, 1, 1], _applicationOptions.DidDomainName), [1, 1, 1, 1, 1], basicTier!.Id, "USRa");
Modules/Devices/src/Devices.Application/Users/Commands/SeedTestUsers/Handler.cs
Outdated
Show resolved
Hide resolved
tnotheis
commented
Nov 26, 2024
...ions/IdentityDeletionJobs/test/Job.IdentityDeletion.Tests/Tests/ActualDeletionWorkerTests.cs
Outdated
Show resolved
Hide resolved
…-its-identity-was-deleted
MH321Productions
requested changes
Nov 27, 2024
...vices.Application/Identities/Queries/IsIdentityOfUserDeleted/IsIdentityOfUserDeletedQuery.cs
Outdated
Show resolved
Hide resolved
…-its-identity-was-deleted
tnotheis
force-pushed
the
possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
branch
from
November 28, 2024 15:13
c968c1e
to
d3e03f9
Compare
…-its-identity-was-deleted
…-out-whether-its-identity-was-deleted' into possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
…Hasher" This reverts commit d3e03f9.
…-its-identity-was-deleted
…-its-identity-was-deleted # Conflicts: # Modules/Devices/src/Devices.Infrastructure/Persistence/Repository/IdentitiesRepository.cs
tnotheis
force-pushed
the
possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
branch
from
December 2, 2024 11:37
fee4967
to
c9e4b94
Compare
MH321Productions
approved these changes
Dec 2, 2024
tnotheis
deleted the
possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
branch
December 2, 2024 12:18
MH321Productions
added a commit
that referenced
this pull request
Dec 4, 2024
MH321Productions
added a commit
that referenced
this pull request
Dec 9, 2024
…nymized during identity deletion (#962) * fix: Revert wrong test user infos introduced in #949 * feat: Add methods for anonymizing the ForIdentity property * feat: Add methods for querying and updating relationship templates * feat: Add domain error for a non-personalized relationship template * feat: Add command, handler and validator for anonymizing personalized relationship templates for an Identity * feat: Add anonymization command to IdentityDeleter * test: Add unit tests for the IdentityDeleter and the relationship template anonymization method * chore: Make loop more readable * feat: Add anonymization logic to Token class * feat: Add didDomainName to Token application options * feat: Add repository methods for querying and updating tokens * feat: Add command, handler and validator for anonymizing all tokens for an identity * feat: Add anonymization command to token identity deleter * feat: Add unit tests for anonymizing tokens * chore: Add forIdentity column to bruno POST /Tokens request * chore: Add didDomainName to test appsettings --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist