Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility for a device to find out whether its identity was deleted #949

Conversation

tnotheis
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@tnotheis tnotheis added the enhancement New feature or request label Nov 26, 2024
@tnotheis tnotheis requested a review from Copilot November 26, 2024 08:18
@tnotheis tnotheis self-assigned this Nov 26, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 29 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)
  • Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Challenges/POST.feature: Language not supported
  • Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Identities/IsDeleted/GET.feature: Language not supported
  • Modules/Devices/src/Devices.Application/Identities/Queries/IsIdentityOfUserDeleted/Handler.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Application/Infrastructure/Persistence/Repository/IIdentitiesRepository.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Application/Identities/Queries/IsIdentityOfUserDeleted/Validator.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Application/Identities/Queries/IsIdentityOfUserDeleted/IsIdentityOfUserDeletedQuery.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Application/Identities/Commands/HandleCompletedDeletionProcess/Handler.cs: Evaluated as low risk
  • Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/ChallengesStepDefinitions.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Application/DTOs/IdentityDeletionProcessDetailsDTO.cs: Evaluated as low risk
  • Applications/ConsumerApi/src/DevicesDbContextSeeder.cs: Evaluated as low risk
  • Applications/IdentityDeletionJobs/src/Job.IdentityDeletion/Workers/ActualDeletionWorker.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Application/Identities/Queries/GetDeletionProcessesAuditLogs/Handler.cs: Evaluated as low risk
  • BuildingBlocks/src/BuildingBlocks.SDK/Endpoints/Common/EndpointClient.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.Domain/Entities/Identities/IdentityDeletionProcessAuditLogEntry.cs: Evaluated as low risk
  • Modules/Devices/src/Devices.ConsumerApi/Controllers/IdentitiesController.cs: Evaluated as low risk
Comments skipped due to low confidence (1)

Modules/Devices/src/Devices.Application/Users/Commands/SeedTestUsers/Handler.cs:26

  • The use of [1, 1, 1, 1, 1] for the identity address and key is incorrect. These should be byte arrays, not lists. Replace [1, 1, 1, 1, 1] with new byte[] { 1, 1, 1, 1, 1 }.
var identityA = Identity.CreateTestIdentity(IdentityAddress.Create([1, 1, 1, 1, 1], _applicationOptions.DidDomainName), [1, 1, 1, 1, 1], basicTier!.Id, "USRa");

@tnotheis tnotheis marked this pull request as ready for review November 26, 2024 11:00
@tnotheis tnotheis force-pushed the possibility-for-a-device-to-find-out-whether-its-identity-was-deleted branch from c968c1e to d3e03f9 Compare November 28, 2024 15:13
mergify bot and others added 7 commits November 29, 2024 06:48
…-out-whether-its-identity-was-deleted' into possibility-for-a-device-to-find-out-whether-its-identity-was-deleted
…-its-identity-was-deleted

# Conflicts:
#	Modules/Devices/src/Devices.Infrastructure/Persistence/Repository/IdentitiesRepository.cs
@tnotheis tnotheis force-pushed the possibility-for-a-device-to-find-out-whether-its-identity-was-deleted branch from fee4967 to c9e4b94 Compare December 2, 2024 11:37
@tnotheis tnotheis merged commit 1035c98 into main Dec 2, 2024
24 checks passed
@tnotheis tnotheis deleted the possibility-for-a-device-to-find-out-whether-its-identity-was-deleted branch December 2, 2024 12:18
MH321Productions added a commit that referenced this pull request Dec 9, 2024
…nymized during identity deletion (#962)

* fix: Revert wrong test user infos introduced in #949

* feat: Add methods for anonymizing the ForIdentity property

* feat: Add methods for querying and updating relationship templates

* feat: Add domain error for a non-personalized relationship template

* feat: Add command, handler and validator for anonymizing personalized relationship templates for an Identity

* feat: Add anonymization command to IdentityDeleter

* test: Add unit tests for the IdentityDeleter and the relationship template anonymization method

* chore: Make loop more readable

* feat: Add anonymization logic to Token class

* feat: Add didDomainName to Token application options

* feat: Add repository methods for querying and updating tokens

* feat: Add command, handler and validator for anonymizing all tokens for an identity

* feat: Add anonymization command to token identity deleter

* feat: Add unit tests for anonymizing tokens

* chore: Add forIdentity column to bruno POST /Tokens request

* chore: Add didDomainName to test appsettings

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants