Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether a relationship can be established with a given identity #808

Merged
merged 26 commits into from
Aug 26, 2024
Merged

Check whether a relationship can be established with a given identity #808

merged 26 commits into from
Aug 26, 2024

Conversation

MH321Productions
Copy link
Contributor

@MH321Productions MH321Productions commented Aug 21, 2024 •
edited by daniel-almeida-konkconsulting
Loading

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@MH321Productions MH321Productions added the enhancement New feature or request label Aug 21, 2024
@MH321Productions MH321Productions self-assigned this Aug 21, 2024
daniel-almeida-konkconsulting
daniel-almeida-konkconsulting suggested changes Aug 21, 2024
View reviewed changes
....Application/Relationships/Queries/CanEstablishRelationship/CanEstablishRelationshipQuery.cs Outdated Show resolved Hide resolved
...rc/Relationships.Application/Relationships/Queries/CanEstablishRelationship/Handler.Tests.cs Outdated Show resolved Hide resolved
...hips/src/Relationships.Application/Relationships/Queries/CanEstablishRelationship/Handler.cs Outdated Show resolved Hide resolved
...hips/src/Relationships.Application/Relationships/Queries/CanEstablishRelationship/Handler.cs Outdated Show resolved Hide resolved
...hips/src/Relationships.Application/Relationships/Queries/CanEstablishRelationship/Handler.cs Outdated Show resolved Hide resolved
...hips/src/Relationships.Application/Relationships/Queries/CanEstablishRelationship/Handler.cs Outdated Show resolved Hide resolved
Modules/Relationships/src/Relationships.ConsumerApi/Controllers/RelationshipsController.cs Outdated Show resolved Hide resolved
Modules/Relationships/src/Relationships.ConsumerApi/Controllers/RelationshipsController.cs Outdated Show resolved Hide resolved
@HunorTotBagi
Copy link
Member

After manual testing I can confirm that everything is working as expected.

Relationship status canCreate
Rejected true ✅
Revoked true ✅
ReadyForDeletion true ✅
Pending false ✅
Active false ✅
Terminated false ✅
DeletionProposed false ✅

✅ - behaves as expected

HunorTotBagi
HunorTotBagi previously approved these changes Aug 23, 2024
View reviewed changes
tnotheis
tnotheis requested changes Aug 26, 2024
View reviewed changes
Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Relationships/GET.feature Outdated Show resolved Hide resolved
Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Relationships/GET.feature Outdated Show resolved Hide resolved
Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Relationships/GET.feature Outdated Show resolved Hide resolved
Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Relationships/GET.feature Outdated Show resolved Hide resolved
Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Features/Relationships/GET.feature Outdated Show resolved Hide resolved
Applications/ConsumerApi/test/ConsumerApi.Tests.Integration/Helpers/Utils.cs Show resolved Hide resolved
...nsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/RelationshipsStepDefinitions.cs Outdated Show resolved Hide resolved
...nsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/RelationshipsStepDefinitions.cs Outdated Show resolved Hide resolved
...nsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/RelationshipsStepDefinitions.cs Outdated Show resolved Hide resolved
...nsumerApi/test/ConsumerApi.Tests.Integration/StepDefinitions/RelationshipsStepDefinitions.cs Outdated Show resolved Hide resolved
@MH321Productions MH321Productions enabled auto-merge (squash) August 26, 2024 15:01
@MH321Productions MH321Productions merged commit 5a4d55e into main Aug 26, 2024
23 checks passed
@MH321Productions MH321Productions deleted the NMSHDB-190-identity-checking-whether-a-relationship-can-be-established branch August 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

@daniel-almeida-konkconsulting daniel-almeida-konkconsulting daniel-almeida-konkconsulting left review comments

@HunorTotBagi HunorTotBagi Awaiting requested review from HunorTotBagi

Assignees

@MH321Productions MH321Productions

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MH321Productions @HunorTotBagi @tnotheis @daniel-almeida-konkconsulting