Consumer API: Block new relationship when old one is in status deletion proposed #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnotheis
requested review from
Dannyps,
NikolaVetnic and
daniel-almeida-konkconsulting
jkoenig134
reviewed
Aug 9, 2024
Modules/Relationships/src/Relationships.Domain/Aggregates/Relationships/Relationship.cs
Show resolved
Hide resolved
Dannyps
approved these changes
Aug 9, 2024
|
@britsta FYI |
tnotheis
changed the title
tnotheis
deleted the
block-new-relationship-when-old-one-is-in-status-deletion-proposed
branch
| } | ||
|
|
||
| [Fact] | ||
| public void A_new_relationship_can_be_created_after_decomposing_the_old_one() | ||
| public void Cannot_create_Relationship_if_terminated_Relationship_exists() |
There was a problem hiding this comment.
Wasn't this tested in the first test above?
There was a problem hiding this comment.
Oh man... I forgot to delete the old tests and rename the new one (it still contains "2" in its name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist