Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unnecessary handler tests #795

Merged
merged 45 commits into from
Sep 2, 2024
Merged

Delete unnecessary handler tests #795

merged 45 commits into from
Sep 2, 2024

Conversation

daniel-almeida-konkconsulting
Copy link
Contributor

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@daniel-almeida-konkconsulting daniel-almeida-konkconsulting added test This pull request contains only new or changed tests refactoring Refactoring of code labels Aug 8, 2024
@Dannyps Dannyps self-requested a review August 9, 2024 08:05
@daniel-almeida-konkconsulting daniel-almeida-konkconsulting marked this pull request as ready for review August 12, 2024 14:46
HunorTotBagi
HunorTotBagi previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@HunorTotBagi HunorTotBagi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried my best to do a review on this PR but everything looks good to me.

mergify bot and others added 10 commits August 26, 2024 05:48
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
b4fa0c4
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
2aba923
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
415303f
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
2024a59
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
819ecb4
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
5e16646
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
6108e56
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
3911720
@mergify
Merge branch 'main' into NMSHDB-183-delete-unnecessary-handler-tests
26dac62
@daniel-almeida-konkconsulting
fix: use valid identity address, albeit a non existent one, to avoid …
4f39b51 
…400 error before 404
@daniel-almeida-konkconsulting daniel-almeida-konkconsulting merged commit 8fce9d5 into main Sep 2, 2024
23 checks passed
@daniel-almeida-konkconsulting daniel-almeida-konkconsulting deleted the NMSHDB-183-delete-unnecessary-handler-tests branch September 2, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnotheis tnotheis tnotheis approved these changes

@NikolaDmitrasinovic NikolaDmitrasinovic NikolaDmitrasinovic left review comments

@HunorTotBagi HunorTotBagi HunorTotBagi left review comments

@Dannyps Dannyps Awaiting requested review from Dannyps

Assignees

@daniel-almeida-konkconsulting daniel-almeida-konkconsulting

Labels
refactoring Refactoring of code test This pull request contains only new or changed tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-almeida-konkconsulting @tnotheis @HunorTotBagi @NikolaDmitrasinovic