Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationship decompose route does not exist #724

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Relationship decompose route does not exist #724

merged 6 commits into from
Jul 2, 2024

Conversation

tnotheis
Copy link
Member

@tnotheis tnotheis commented Jul 2, 2024 •
edited
Loading

The merge of the release branch into main seems to have deleted the decompose route. This PR re-adds it.
It also

  • Removes some unused nuget packages
  • Removes the RelationshipDecomposedDomainEvent and the corresponding handler. It was some orphaned code. Then event was never published.
  • Makes sure, that external events are not created in case the status of a relationship changes to "ReadyForDeletion".

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@tnotheis tnotheis added the bug Something isn't working label Jul 2, 2024
@tnotheis tnotheis self-assigned this Jul 2, 2024
@tnotheis tnotheis requested a review from Dannyps July 2, 2024 12:47
@tnotheis tnotheis enabled auto-merge (squash) July 2, 2024 13:03
@tnotheis tnotheis merged commit ea16edc into main Jul 2, 2024
21 checks passed
@tnotheis tnotheis deleted the relationship-decompose-route-does-not-exist branch July 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dannyps Dannyps Dannyps approved these changes

@daniel-almeida-konkconsulting daniel-almeida-konkconsulting Awaiting requested review from daniel-almeida-konkconsulting

Assignees

@tnotheis tnotheis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnotheis @Dannyps