Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin UI: Overview of all identities #593

Merged
merged 111 commits into from
Apr 26, 2024
Merged

Admin UI: Overview of all identities #593

merged 111 commits into from
Apr 26, 2024

Conversation

stamenione
Copy link
Contributor

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Description

image

stamenione and others added 24 commits April 3, 2024 11:07
@stamenione
feat: add data table 2
c7a88e7
@stamenione @mergify
@jkoenig134 @tnotheis
Admin UI: Login page (#584)
a78c2d4 
* chore: adapt the header appearance

* chore: add new design for login  box

* chore: adapt login position in padding widget  via screen size

* chore: logic for displaying the error message for attempted login

* chore: remove error message

* chore: add error message

* chore: change the button colors and add a text button

* chore: remove Visibility widget

* chore: add text style for text button

* chore: change todo comment according to the flutter style

* refactor: extract the app title to be a separate widget

* refactor: extract text field to be reusable

* chore: use new app title widget

* chore: use custom text field

* chore: make the text field fixed height

* chore: rename variables and make them private

* chore: update imports

* chore: use extracted app title widget

* chore: remove unnecessary widgets and center the card

* chore: add custom colors and move login button to the bottom

* chore: remove unused import

* refactor: rename folder and files appropriately

* refactor: extract sized box into a separate custom widget

* refactor: extract elevated button into a separate custom widget

* chore: make the variable private

* chore: local variable should not start with underscore

* chore: add DI for baseUrl

* fix: untangle coding

* fix: imports

* fix: make CustomColors easier accessible

* fix: make prettier

* feat: add gaps

* fix: rename file

* refactor: remove CustomX, make whole logic with one variable

* fix: bool logic

* ci: add jkoenig134 as codeowner

* chore: remove accidentally committet code

* fix: undo change

* refactor: simplify login screen

* refactor: simplify app title

* refactor: PR comments

* chore: inline svg picture

* chore: make multi line params last

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Julian König <[email protected]>
Co-authored-by: Timo Notheisen <[email protected]>
@stamenione
Merge branch 'main' into NMSHDB-100-admin-ui-overview-of-all-identities
231616b
@stamenione
feat: add multiselect
0c96b5e
@stamenione
feat: add data table 2 and multi dropdown
07e022c
@stamenione
fix: remove dependencies from wrong pubspec
8be91b5
@stamenione
fix: remove filter when there are no filters applied
ea6126f
@stamenione
chore: add builders
413e889
@stamenione
chore: display the IdentityOverview
e20f46f
@stamenione
fix: change the widget
a649f3e
@stamenione
feat: add identity overview
ce2d911
@stamenione
feat: add components
b99519a
@stamenione
feat: add shared filter fields
ab5f8d0
@stamenione
chore: tier overview (wip)
6b652bc
@stamenione
chore: identity details (wip)
aa8670e
@stamenione
chore: pagination (wip)
d901930
@jkoenig134
chore: update rowCount
12f4799
@stamenione
Merge branch 'NMSHDB-100-admin-ui-overview-of-all-identities' of http…
a80c188 
…s://github.com/nmshd/backbone into NMSHDB-100-admin-ui-overview-of-all-identities
@stamenione
fix: pagination
75be191
@stamenione
fix: pagination
5482b02
@stamenione
chore: remove comment and print
a08b85f
@stamenione
chore: remove comments
1564bbf
@stamenione
Merge branch 'main' into NMSHDB-100-admin-ui-overview-of-all-identities
fef208f
@stamenione
fix: revert created files
b71f118
@stamenione stamenione added the enhancement New feature or request label Apr 8, 2024
@stamenione stamenione self-assigned this Apr 8, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 8, 2024 •
edited
Loading

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@stamenione stamenione requested a review from jkoenig134 April 26, 2024 05:45
jkoenig134
jkoenig134 requested changes Apr 26, 2024
View reviewed changes
AdminUi/apps/admin_ui/lib/core/widgets/filters/date_filter.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/core/widgets/filters/date_filter.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/core/widgets/filters/date_filter.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/core/widgets/filters/date_filter.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/core/widgets/filters/number_filter.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/home/identities_overview/identities_data_table_source.dart Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/home/identities_overview/identities_data_table_source.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/home/identities_overview/identities_data_table_source.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/home/identities_overview/identities_filter.dart Outdated Show resolved Hide resolved
AdminUi/apps/admin_ui/lib/home/identities_overview/identities_filter.dart Outdated Show resolved Hide resolved
@stamenione stamenione merged commit d41de55 into main Apr 26, 2024
17 checks passed
@stamenione stamenione deleted the NMSHDB-100-admin-ui-overview-of-all-identities branch April 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

@tnotheis tnotheis Awaiting requested review from tnotheis tnotheis is a code owner

Assignees

@stamenione stamenione

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stamenione @jkoenig134