Helm Chart: Update Consumer API, Admin UI and Admin CLI #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnotheis
changed the title
NikolaVetnic
approved these changes
Jan 22, 2024
tnotheis
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: update adminui * feat: update consumerapi
tnotheis
added a commit
that referenced
this pull request
Jan 22, 2024
* feat: update adminui * feat: update consumerapi
stamenione
added a commit
that referenced
this pull request
Feb 12, 2024
* fix: tests now run when script is used * chore: add data to support breadcrumb label * feat: implement BreadcrumbService and add appropriate tests for BreadcrumbService * feat: add breadcrumb component to AdminUI * chore: add breadcrumb component to module and in appropriate place of view * chore: clear localStorage for breadcrumb history * fix: create a deep copy of the result * chore: add css styling for breadcrumbs * fix: eslint errors and add router module * chore: click on one of the sidebar items resets the breadcrumbs * chore: ignoring the history changes * chore: prettier * chore: unnecessary set of the breadcrumb history * chore: display dynamic data if there is one instead of breadcrumb label * chore: prettier * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * chore: now using session storage * ci: trigger pipelines * chore: remove unused breadcrumb data * refactor: enhance logout in AuthService to clear breadcrumb history * test: now use map instead of forEach * refactor: unify variable names and remove redundant type definitions as well return array of breadcrumbs in getBreadcrumbHistory * chore: prettier * chore: replace forEach and map with simple for loop * ci: trigger pipelines * ci: trigger pipelines * chore: unnecessary type definition * chore: remove null suppressing operator * chore: give a variable a proper name * chore: remove unnecessary array duplication --------- Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
tnotheis
added a commit
that referenced
this pull request
Feb 19, 2024
* chore: fix nullability in IDbContext * fix: get rid of infinite recursion * chore: remove unused method * refactor: fix nullability of PnsRegistrationsRepository.FindByDeviceId * refactor: make properties required * chore: add comment clarifying the usage of the empty ctor * chore: remove unused directive * chore: remove unused directive * refactor: set properties as nullable since any of two options could be missing * refactor: mark return type as nullable since it can indeed return null refactor: remove nullable mark from the input param as it is never null * refactor: mark return type as nullable since it can return null and the single call of the method suppresses null warnings * refactor: make property required as it is the single property of the class * refactor: put the nullability suffix back * refactor: mark the parameter as nullable as it can clearly be null * chore: remove unused directive * refactor: add nullable suppression and '?' suffix * chore: change parameter order to match the class * refactor: remove '?' suffix as options is never null * refactor: suppress null warnings as the object is instantiated as empty but the properties are then immediately set * refactor: avoid possible multiple enumeration * refactor: remove null suppression as AppId is never null * refactor: suppress null warning as it presumably can never be null * refactor: make the return type not nullable * refactor: throw exception in case of bundle being null * refactor: make the property nullable * chore: revert change * refactor: make the method signature match the one it is calling * refactor: avoid possible multiple enumeration * refactor: make the method signature match the one it is calling * refactor: add '?' suffix where required * refactor: remove meaningless '?' suffix * refactor: remove unnecessary async keyword * refactor: add '?' suffix where needed * refactor: throw exception in case that public key cannot be deserialized * refactor: throw exception in case that signature cannot be deserialized * chore: fix formatting issues * refactor: remove unnecessary null check * refactor: suppress null warning as ToModel never returns null * refactor: make input parameter nullable as it is checked for null value subsequently * refactor: suppress nullable warning as the class is never instantiated manually * refactor: suppress warning with 'null!' initializers as ClientDTO is only instantiated through mapper * refactor: make properties required * fix: remove required keyword as it seems to break some tests * refactor: remove 'null!' initializers as they seem to break some tests * fix: remove 'null!' initializers as they seem to break some tests * fix: remove 'null!' initializers as they seem to break some tests * fix: revert changes that seem to break some tests * refactor: revert to changes previously suspected to crash the tests * fix: wip * Revert "fix: wip" This reverts commit e6d96a7. * Revert "refactor: revert to changes previously suspected to crash the tests" This reverts commit e3d4a1a. * chore: remove redundant nullable directive * refactor: make properties required * chore: comment out the tests which are to be ignored at the moment * refactor: make property required * refactor: check expression for null * refactor: suppress null value as UserName is never null * refactor: throw exceptions where appropriate * refactor: suppress null value on instantiation * refactor: throw exception if basic tier not found * Revert "refactor: throw exception if basic tier not found" This reverts commit 6de40a4. * Revert "refactor: suppress null value on instantiation" This reverts commit 466e29b. * Revert "refactor: throw exceptions where appropriate" This reverts commit 0069918. * Revert "refactor: suppress null value as UserName is never null" This reverts commit 8be174e. * Revert "refactor: check expression for null" This reverts commit 2851b0e. * Revert "refactor: make property required" This reverts commit 08333ea. * refactor: make Provider property nullable * refactor: check expression for null * refactor: check expression for null * refactor: suppress null value as UserName is never null * chore: suppress null value for Read, ReadValue and ReadList * refactor: suppress null value on instantiation * refactor: throw exception if basic tier not found * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * refactor: suppress null warning since basic tier always exists * chore: fix formatting issues * refactor: suppress null warnings as values can never be null * refactor: suppress null warning since basic tier always exists * refactor: suppress the null warning since default value of identity is null * refactor: add '?' suffix to match the signature of base method * refactor: cast ids to list * refactor: remove unused field * refactor: suppress null value as UserName is never null * refactor: cast devices to list * refactor: add null checks for nullable parameters * chore: fix formatting issues * refactor: suppress null value as UserName is never null * chore: fix typo * refactor: make property nullable to match the nullability of non-dto class and add null check * refactor: fix formatting * refactor: add null checks due to properties being nullable * chore: fix formatting * refactor: match nullability of the base class return type * refactor: match nullability of the base class return type * refactor: initialize properties of SendResult with null! (not possible to use required but the values are never null) * refactor: make properties of ApnsMessageBuilder nullable * refactor: disable 'property unused' warnings (reluctant to remove unused class properties) * refactor: make property nullable * refactor: suppress nullability warning (class is never instanced in code) * refactor: remove null check as the value should never be null * refactor: mark Property as nullable (insantiated manually once where Data is set) * refactor: mark property as nullable * refactor: mark properties as nullable * refactor: mark properties as nullable * refactor: mark properties as nullable (insantiated manually once where values are set) * refactor: mark properties as nullable * refactor: mark properties as nullable (insantiated manually once where values are set) * refactor: make property nullable * refactor: make properties nullable * refactor: make properties nullable * refactor: make properties nullable * chore: remove unused directive * refactor: make property nullable (instantiated manually with empty ctor) * fix: return null check and disable the warning with comment * refactor: suppress null warnings in case of all properties previously marked as nullable * refactor: cast tiers to list * refactor: suppress nullable warnings * refactor: match signature of FindByAddress in IIdentitiesRepository to Task.FromResult refactor: match signature of FindByAddress implementations to implemented interface * refactor: suppress nullability warnings as JsonElement.Deserialize is presumed to work correctly * refactor: suppress null warnings as the instanced objects cannot be null * refactor: suppress null warnings in tests * refactor: fix nullability of CreateClientCommand * refactor: add invalid default values to ApplicationOptions to be able to make them not nullable * refactor: mkae RegisterDeviceCommand properties required (recursively) * refactor: fix nullability warnings in TiersRepository * refactor: make DeleteDeviceCommand.Id required * refactor: make ClientDTO.CreatedAt required * refactor: make ChallengeDTO.Id required * refactor: simplify IdentitySummaryDTO * refactor: fix nullability issues in DynamicJsonConverter * refactor: add some required modifiers * chore: formatting * refactor: make all properties except ClientId required - ClientId is nullable in Identity * refactor: make Properties required * refactor: make Property required * refactor: mark property as nullable * refactor: make property required to avoid compiler error * refactor: rearrange properties to match domain class refactor: pass in entire identity to ctor * refactor: pass the entire identity to base ctor * refactor: pass identity to ctor * refactor: remove redundant null warning suppression * refactor: remove redundant nullability suppression * refactor: remove redundant nullability suppression * refactor: make properties of DatawalletModifiedIntegrationEvent required * refactor: remove null warning suppression for usage of DatawalletModifiedIntegrationEvent * chore: fix formatting * refactor: make property of ExternalEventCreatedIntegrationEvent required and remove null warning suppression * refactor: remove null warning suppression * refactor: revert changes as they are to be done later * chore: remove pointless line breaks * chore: enhance formatting * chore: enhance formatting * chore: remove pointless line break * refactor: make properties of CreateIdentityResponse and CreateIdentityResponseDevice required * refactor: remove the '?' suffix as it makes no sense, though the class is never instanced in code and I cannot be 100% sure * refactor: make properties of NotificationTextAttribute required instead of nullable * chore: disable meaningless warnings with comments * refactor: use collection expression to initialize list * refactor: make properties of CustomOpenIddictEntityFrameworkCoreApplication required and remove redundant null warning suppression * refactor: initialize field with null in EF Core required ctor * refactor: initialize DbSets with 'null!' as discussed * refactor: remove redundant null warning suppression * refactor: mark return type as nullable * refactor: remove redundant null warning suppression * refactor: update return type * refactor: update return type and remove redundant null warning suppression * refactor: update return type * refactor: update return type and remove redundant null warning suppression * refactor: remove redundant null warning suppression * chore: add line break * refactor: revert changes as they are to be done later * refactor: remove redundant null warning suppression * refactor: remove redundant null warning suppression * refactor: match return type of the interface * refactor: add null warning suppression as _identity is not null * refactor: match return type of the interface * refactor: remove redundant null warning suppression * chore: fix formatting * refactor: remove redundant nullability suffix * Revert "refactor: remove redundant nullability suffix" This reverts commit 166c3f3. * refactor: revert changes to match the possible state of same property in ApplicationUser * refactor: replace null warning suppression with an exception throw * refactor: revert changes as they are to be done later * refactor: replace null warning suppression with an exception throw * refactor: revert changes to match the possible state of same property in ApplicationUser * refactor: make return type nullable * refactor: throw exception if OAuthClient not found * refactor: remove redundant null warning suppression * fix: make return type nullable instead of throwing an exception * refactor: update default values * refactor: change to FirstAsync call as basic tier always exists since it's seeded to the db * refactor: make return type not nullable * fix: revert to previous state * fix: revert changes done earlier * ci: trigger pipelines * refactor: make return type nullable and possibly return null * refactor: remove null warning suppression and return nullable type * refactor: change to FirstAsync call as basic tier always exists since it's seeded to the db and make return type non nullable * refactor: make return type nullable * refactor: change FirstAsync into FirstOrDefaultAsync * Revert "refactor: change FirstAsync into FirstOrDefaultAsync" This reverts commit 68c9ed6. * refactor: change FirstAsync into FirstOrDefaultAsync * chore: disable warning temporarily * refactor: remove null check * chore: formatting * chore: remove null suppression operator * chore: remove default values from PaginationOptions properties * feat: fix nullability in SendResult * chore: resolve nullability problems * chore: extract variable * chore: fix nullability issues for entity constructors * chore: remove redundant using directives * chore: add words to resharper dictionary * chore: remove unused setters from Identity * chore: fix some compiler warnings * chore: remove redundant assignment of null * refactor: rename GetBasicTierAsync to FindBasicTier to match naming convention * chore: fix some nullability issues * chore: formatting * test: fix DeletedAt comparison * fix: add CreatedAt and PublicKey to IdentityEntityTypeConfiguration * chore: formatting --------- Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
tnotheis
added a commit
that referenced
this pull request
Feb 20, 2024
#497) * refactor: make property required as it makes no sense to be null * refactor: make properties required as the values are always passed through via json object * refactor: update input parameter to match the base method and supress nullability warning with '!' * fix: remove required keywords as it seems to break the tests * refactor: make properties nullable * refactor: make property nullable * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * refactor: modify CompareTo so that it complies with standard * refactor: make properties required instead of nullable * ci: trigger pipelines * chore: add nullable enable property group * chore: add nullable enable property group for tests * refactor: make Id required * refactor: make Id required * refactor: suppress possible null reference warning * refactor: make RootFolder required * refactor: make nullable * refactor: make SyncRunId nullable * refactor: remove redundant null expression * refactor: remove ? since setupOptions is never null * chore: fix comment typo * chore: fix typo in test name * refactor: make SyncRun nullable * refactor: mappingHints is never null * refactor: remove null check since id is not null * refactor: make ConverterMappingHints nullable * refactor: make Modifications nad Id required * refactor: make SyncRun required * refactor: make properties required * refactor: declare as nullable * refactor: expression is always false * refactor: make BlobStorageOptions nullable * refactor: null suppression * refactor: remove null check * refactor: make properties required * refactor: fix multiple nullability issues * refactor: remove _payload null check * refactor: assign null! to DbContext properties * refactor: add throw new ArgumentNullException * refactor: make properties required * refactor: make ErrorCode nullable * refactor: make nullable * refactor: make nullable type * refactor: remove null conditionall operator * chore: suppress nullability warning as null is never returned * refactor: update interface return type * refactor: suppress null warnings as the object is instantiated as empty but the properties are then immediately set * refactor: make properties required to match SyncRun class * refactor: make fields nullable * refactor: suppress nullability warnings as fields are never null (they are marked as nullable since they are filled outside of ctor) refactor: remove null check in case of events as it is never null * refactor: remove null check in case of events as it is never null * refactor: make fields nullable * refactor: suppress nullability warnings (field is effectively never null though it is null after leaving ctor) * refactor: suppress warning with a comment as no other solution is offered * refactor: make property required * refactor: make properties required * refactor: make properties nullable * refactor: make fields nullable and suppress nullability warnings * refactor: remove conditional access and unreachable code * chore: initialize properties with null! instead of using null suppression on usage * chore: initialize properties with null! in ef core constructors * fix: make EncryptedPayload and PayloadCategory optional * test: fix compiler error * chore: add words to resharper dicitionary * chore: cleanup code * chore: make properties of ExternalEventResult required * chore: fix nullability warnings --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Hunor Tot-Bagi <[email protected]> Co-authored-by: Timo Notheisen <[email protected]>
tnotheis
added a commit
that referenced
this pull request
May 6, 2024
* feat: add message service to the AdminUi * feat: add identity details message component to the AdminUi * feat: add pagination to messages overview * feat: add custom AdminUi rerouting strategy to refresh components * refactor: use recipients array in the AdminUi messages component * feat: add MessageOverview DbSet to AdminUi * feat: add MessagesController to the AdminUi * chore: create postgres migrations for MessagesOverview * refactor: rename RouteReuseStrategy class name * feat: add Message Recipients Dialog to the AdminUi * feat: use Message Recipients dialog in the Identity details component * refactor: simplify Identity details Message Overview component * chore: create sqlserver migrations for Messages Overview in the AdminUi * chore: compile sqlserver models in the AdminUi * refactor: use table to display identity details Message Recipients dialog * refactor: improve Messages table in the AdminUi * fix: removed pre merge compiled models in the AdminUi * fix: add missing group by in the postgres MessagesOverview migration * fix: simplified Message service in the AdminUi * fix: MessageRecipients should use a composite key * chore: remade adminUi postgres migrations * chore: remade adminUi sqlserver migrations * test: add integration tests for MessageOverview in the AdminUi * chore: run dotnet format * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * Helm Chart: Update Consumer API, Admin UI and Admin CLI (#501) * feat: update adminui * feat: update consumerapi * ci: trigger pipeline * chore: now displaying 3 recipients if there is more than 3 * chore: making the dialog a fixed width * chore: prettier * chore: change button text * ci: trigger pipelines * feat: add message method that returns a decrypted body provided correct key is passed in (wip) * feat: add message method that returns a decrypted body provided correct key is passed in (wip) * feat: add message method that returns a decrypted body provided correct key is passed in (wip) * feat: add libsodium decrypter (wip) * refactor: implement interface * fix: remove unnecessary tests * chore: add overflow * chore: template for message preview and download (wip) * chore: prettier * chore: display error message (wip) * test: add HandlerTest for decrypting messages with symmetric key * refactor: add ExtractSymmetricKey method * refactor: move deserializedSecret to correct location * feat: implement handler to decrpyt message with symmetric key * chore: remove comment * chore: fix property naming convention * chore: prettier * fix: failing tests (todo: fix symmetric key passing) * fix: compiler errors & formatting * Revert "feat: add message method that returns a decrypted body provided correct key is passed in (wip)" This reverts commit 19357bd. * Revert "feat: add message method that returns a decrypted body provided correct key is passed in (wip)" This reverts commit b0c91ea. * Revert "feat: add libsodium decrypter (wip)" This reverts commit d5a41a8. * Revert "refactor: implement interface" This reverts commit a0e84cb. * Revert "chore: add overflow" This reverts commit beb43ec. * Revert "chore: template for message preview and download (wip)" This reverts commit fedb894. * Revert "test: add HandlerTest for decrypting messages with symmetric key" This reverts commit 8849591. * Revert "refactor: add ExtractSymmetricKey method" This reverts commit 90d0fef. * Revert "feat: implement handler to decrpyt message with symmetric key" This reverts commit c542e2d. * chore: remove unused directives * ci: trigger pipelines * fix: add missing dependencies * chore: moved to project AdminApi * chore: remove duplicate health check project * ci: trigger pipelines * fix: fixed after merge with 'main' * fix: nullable compiler warnings * fix: dependency vulnerability * chore: remove exclude flag for package without vulnerability * test: disable json schema validation * chore: remove nullable property group * fix: use recipient information table instead of message recipients view * fix: specify schema name * fix: add missing schema name to view --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vladimir Vuckovic <[email protected]> Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: Nikola Vetnić <[email protected]> Co-authored-by: Hunor Tot-Bagi <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Daniel Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist