Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Postgres healthcheck package #380

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update Postgres healthcheck package #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f5b4e
chore: update nuget package
tnotheis Nov 16, 2023
05734f8
chore: unignore package in dependabot config
tnotheis Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ updates:
patterns:
- "*"
exclude-patterns:
- "AspNetCore.HealthChecks.NpgSql"
- "Npgsql.EntityFrameworkCore.PostgreSQL"
reviewers:
- "tnotheis"
Expand Down
2 changes: 1 addition & 1 deletion AdminUi/src/AdminUi/AdminUi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<PackageReference Include="Serilog.Sinks.Http" Version="8.0.0" />
<PackageReference Include="Serilog.Sinks.Seq" Version="5.2.3" />
<!-- CAUTION: Do not upgrade 'AspNetCore.HealthChecks.NpgSql' before the following issue is resolved: https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/issues/1993 -->
<PackageReference Include="AspNetCore.HealthChecks.NpgSql" Version="[6.0.2]" />
<PackageReference Include="AspNetCore.HealthChecks.NpgSql" Version="7.1.0" />
<PackageReference Include="AspNetCore.HealthChecks.SqlServer" Version="7.0.0" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion AdminUi/src/AdminUi/Extensions/IServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public static IServiceCollection AddCustomAspNetCore(this IServiceCollection ser
break;
case "Postgres":
services.AddHealthChecks().AddNpgSql(
npgsqlConnectionString: connectionString,
connectionString: connectionString,
name: moduleName);
break;
default:
Expand Down
3 changes: 1 addition & 2 deletions BuildingBlocks/src/BuildingBlocks.API/BuildingBlocks.API.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
</PropertyGroup>

<ItemGroup>
<!-- CAUTION: Do not upgrade 'AspNetCore.HealthChecks.NpgSql' before the following issue is resolved: https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/issues/1993 -->
<PackageReference Include="AspNetCore.HealthChecks.NpgSql" Version="[6.0.2]" />
<PackageReference Include="AspNetCore.HealthChecks.NpgSql" Version="7.1.0" />
<PackageReference Include="AspNetCore.HealthChecks.SqlServer" Version="7.0.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.13" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="7.0.13" />
Expand Down
2 changes: 1 addition & 1 deletion BuildingBlocks/src/BuildingBlocks.API/Extensions/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public static void AddSqlDatabaseHealthCheck(this IServiceCollection services, s
break;
case "Postgres":
services.AddHealthChecks().AddNpgSql(
npgsqlConnectionString: connectionString,
connectionString: connectionString,
name: name);
break;
default:
Expand Down