Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abl 174 admin api send announcements to specify identities - Intermediate #1018

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Abl 174 admin api send announcements to specify identities - Intermediate #1018

wants to merge 11 commits into from

Conversation

ericbrunner
Copy link
Contributor

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

Note for the reviewer:

  • It's an intermediate PR, to verify if there is something fundamental wrong or missing.
  • Unit Tests get added / updated in next few days.
  • The Announcement IdentityDeleter could not be tested until now. If the appsettings.json updates (DidDomainName) are required is not clear, too.

@ericbrunner ericbrunner added the enhancement New feature or request label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 left review comments

@tnotheis tnotheis Awaiting requested review from tnotheis tnotheis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericbrunner @jkoenig134