Consumer Api: Don't display push notifications for new datawallet modifications

Modules/Devices/src/Devices.Infrastructure/PushNotifications/NotificationTexts/PushNotificationTextProvider.cs

@@ -42,10 +42,10 @@ private NotificationText GetNotificationTextFromResourceManager(Type pushNotific
             var title = _resourceManager.GetString(titleKey, culture);
             var body = _resourceManager.GetString(bodyKey, culture);
 
-            if (title.IsNullOrEmpty())
+            if (title == null)
                 throw new MissingPushNotificationTextException($"Title for notification type '{pushNotificationTypeName}' not found.");
 
-            if (body.IsNullOrEmpty())
+            if (body == null)
                 throw new MissingPushNotificationTextException($"Body for notification type '{pushNotificationTypeName}' not found.");
 
             return new NotificationText(title, body);

Modules/Devices/src/Devices.Infrastructure/Translations/Resources.de.resx

@@ -18,12 +18,6 @@
     <resheader name="writer">
         <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
     </resheader>
-    <data name="DatawalletModificationsCreatedPushNotification.Body" xml:space="preserve">
-        <value>Es sind Neuigkeiten in der App verfügbar.</value>
-    </data>
-    <data name="DatawalletModificationsCreatedPushNotification.Title" xml:space="preserve">
-        <value>Neuigkeiten verfügbar</value>
-    </data>
     <data name="DeletionProcessApprovedPushNotification.Body" xml:space="preserve">
         <value>Ein Löschvorgang einer Ihrer Identitäten wurde bestätigt und wird in Kürze prozessiert.</value>
     </data>

Modules/Devices/src/Devices.Infrastructure/Translations/Resources.it.resx

@@ -18,12 +18,6 @@
     <resheader name="writer">
         <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
     </resheader>
-    <data name="DatawalletModificationsCreatedPushNotification.Body" xml:space="preserve">
-        <value>Nuovi aggiornamenti sono disponibili nell'app.</value>
-    </data>
-    <data name="DatawalletModificationsCreatedPushNotification.Title" xml:space="preserve">
-        <value>Aggiornamenti disponibili</value>
-    </data>
     <data name="DeletionProcessApprovedPushNotification.Body" xml:space="preserve">
         <value>Un processo di eliminazione di una delle Sue identità è stato approvato e verrà elaborato a breve.</value>
     </data>

Modules/Devices/src/Devices.Infrastructure/Translations/Resources.pt.resx

@@ -117,12 +117,6 @@
     <resheader name="writer">
         <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
     </resheader>
-    <data name="DatawalletModificationsCreatedPushNotification.Body" xml:space="preserve">
-    <value>Há atualizações disponíveis na aplicação.</value>
-  </data>
-    <data name="DatawalletModificationsCreatedPushNotification.Title" xml:space="preserve">
-    <value>Atualizações Disponíveis</value>
-  </data>
     <data name="DeletionProcessApprovedPushNotification.Body" xml:space="preserve">
     <value>Um dos processos de eliminação de uma das suas identidades foi aprovado e será processado brevemente.</value>
   </data>

Modules/Devices/src/Devices.Infrastructure/Translations/Resources.resx

@@ -117,12 +117,6 @@
     <resheader name="writer">
         <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
     </resheader>
-    <data name="DatawalletModificationsCreatedPushNotification.Body" xml:space="preserve">
-      <value>New updates are available in the app.</value>
-  </data>
-    <data name="DatawalletModificationsCreatedPushNotification.Title" xml:space="preserve">
-      <value>Updates available</value>
-  </data>
     <data name="DeletionProcessApprovedPushNotification.Body" xml:space="preserve">
       <value>A deletion process of one of your identities has been was approved and will be processed shortly.</value>
   </data>
@@ -183,4 +177,10 @@
     <data name="BackupDeviceUsedPushNotification.Body" xml:space="preserve">
         <value>Your backup device was used.</value>
     </data>
+    <data name="DatawalletModificationsCreatedPushNotification.Body" xml:space="preserve">
+        <value />
+    </data>
+    <data name="DatawalletModificationsCreatedPushNotification.Title" xml:space="preserve">
+        <value />
+    </data>
 </root>

Modules/Devices/test/Devices.Infrastructure.Tests/Tests/PushNotifications/NotificationTexts/PushNotificationTextProviderTests.cs

@@ -1,6 +1,7 @@
 using Backbone.BuildingBlocks.Application.PushNotifications;
 using Backbone.Modules.Devices.Application.Infrastructure.PushNotifications;
 using Backbone.Modules.Devices.Application.Infrastructure.PushNotifications.Announcements;
+using Backbone.Modules.Devices.Application.Infrastructure.PushNotifications.Datawallet;
 using Backbone.Modules.Devices.Domain.Entities.Identities;
 using Backbone.Modules.Devices.Infrastructure.PushNotifications.NotificationTexts;
 
@@ -62,7 +63,8 @@ private static IEnumerable<Type> GetNotificationTypes()
             typeof(TestPushNotification)
                 .Assembly.GetTypes()
                 .Where(t => t.IsAssignableTo(typeof(IPushNotification)) && !t.IsInterface)
-                .Where(t => t != typeof(NewAnnouncementPushNotification)); // `NewAnnouncementPushNotification` does not have a translatable text and must therefore be excluded
+                .Where(t => t != typeof(NewAnnouncementPushNotification)) // `NewAnnouncementPushNotification` does not have a translatable text and must therefore be excluded
+                .Where(t => t != typeof(DatawalletModificationsCreatedPushNotification)); //`DatawalletModificationsCreatedPushNotification` is empty and must therefore be excluded
     }
 
     private class AllSupportedLanguagesExceptEnglishCrossJoinedWithNotificationTypes : TheoryData<CommunicationLanguage, Type>