Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to platform-tools-34.0.3 #115

Merged
merged 1 commit into from
May 31, 2023
Merged

Upgrade to platform-tools-34.0.3 #115

merged 1 commit into from
May 31, 2023

Conversation

Biswa96
Copy link
Collaborator

@Biswa96 Biswa96 commented May 30, 2023

No description provided.

@Biswa96
Copy link
Collaborator Author

Biswa96 commented May 30, 2023

This may break RISC-V platform. This commit may be the reason https://boringssl.googlesource.com/boringssl/+/1967621cc9498a4d775a8a9eaabbcb7a52be8316

@anatol
Copy link
Collaborator

anatol commented May 30, 2023

Is it possible to port (or even better upstream) the cmake files?

@anatol
Copy link
Collaborator

anatol commented May 30, 2023

Cc @SpriteOvO

@SpriteOvO
Copy link
Contributor

For RISC-V, looks like it just needs a simple patch, I will try to upstream it to boringssl in the next few days.

@SpriteOvO
Copy link
Contributor

SpriteOvO commented May 31, 2023

I have compiled the latest boringssl without patching on RISC-V. That commit did not break RISC-V since it just added code files for specific arch and RISC-V doesn't need specific files.

However, the latest boringssl triggers a strange error that looks like a bug from STL or gcc, I'm trying to investigate it, it doesn't relate to android-tools or boringssl I guess, so this PR can be merged safely, and no porting is needed :)

@anatol
Copy link
Collaborator

anatol commented May 31, 2023

Thank you for the confirmation @SpriteOvO

@anatol anatol merged commit 0a31d1b into nmeum:master May 31, 2023
@Biswa96 Biswa96 deleted the 34.0.3 branch May 31, 2023 04:40
@nmeum
Copy link
Owner

nmeum commented Jun 2, 2023

Thank you for the PR! Should I tag a new release or does this warrant further testing? (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants