Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date formatter Strings wrong #64

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Date formatter Strings wrong #64

merged 1 commit into from
Aug 13, 2018

Conversation

hactar
Copy link
Contributor

@hactar hactar commented Aug 13, 2018

The isoformatter uses hh instead of HH and mm instead of MM in its first date format string. This can cause situations where months are read as minutes instead...

(minutes instead of months, wrong order)
@nmdias
Copy link
Owner

nmdias commented Aug 13, 2018

Hi @hactar, looks good. Thank you for contributing 🙏

@nmdias nmdias merged commit a63b3c1 into nmdias:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants