Introduce add subcommand per fetcher type
#35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! Why not have a flag instead? e.g. $ niv add --github ...
$ niv add --docker ...I understand that in that case the help message may become a bit long but at least you can still write $ niv add nmattia/nivwhich I think is invaluable. Or maybe we can have an optional subcommand? is that possible with optparse? |
|
I dont' think we could have a nice help menu with flags since they are not really suitable to group arguments. What about trying to create a special However, I don't know if it is possible with the lib :/ |
|
I gave this a try, I think there are a few solutions: bdd3e98 Let's pair and see what we can come up with! |
nlewo
changed the title
add subcommand per fetcher typeadd subcommand per fetcher type
nlewo
force-pushed
the
subcommand
branch
5 times, most recently
from
25fc4c9 to
98ba9e7
Compare
nlewo
changed the title
add subcommand per fetcher typeadd subcommand per fetcher type
This commit introduces subcommand to the `add` command. These
subcommands permit to specify a fetcher type in order to be able to
specify options per fetcher type. For instance, the `--branch` option is
useless for the `file` fetcher. Thanks to this commit, the `--branch`
option is only displayed in the help of the `niv add github` command.
Some usage examples:
niv add github stedolan/jq
niv add github NixOS/nixpkgs-channels -n nixpkgs -b nixos-18.09
niv add file my-package -v alpha-0.1 -t http://example.com/archive/<version>.zip
This commit also improves parsing of several options: `type`, `url-template` options can no longer be repeated.
Closed
This was referenced Jun 12, 2019
|
Closing, handled in #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces subcommand to the
addcommand. Thesesubcommands permit to specify a fetcher type in order to be able to
specify options per fetcher type. For instance, the
--branchoption isuseless for the
filefetcher. Thanks to this commit, the--branchoption is only displayed in the help of the
niv add githubcommand.Some usage examples:
TODO: