[build-properties] Add field to enable/disable privacy manifest aggre…

…gation (expo#28646)

# Why

There are a few issues right now with privacy manifest aggregation
(facebook/react-native#44410,
facebook/react-native#44402,
facebook/react-native#44402) that I expect will
be fixed in React Native 0.74.2, but in order to ensure that this
doesn't break builds I've disabled it by default and added this build
property to allow folks to toggle it on. We can switch on by default
when 0.74.2 is released and proven to handle some edge cases better.

# How

Same old process for adding a new property

# Test Plan

Run tests

# Checklist

- [x] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [x] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

packages/@expo/config-plugins/src/ios/__tests__/__snapshots__/Maps-test.ts.snap

@@ -250,7 +250,11 @@ target 'HelloWorld' do
     react_native_post_install(
       installer,
       config[:reactNativePath],
-      :mac_catalyst_enabled => false
+      :mac_catalyst_enabled => false,
+      :ccache_enabled => podfile_properties['apple.ccacheEnabled'] == 'true'
+      # Temporarily disable privacy file aggregation by default, until React
+      # Native 0.74.2 is released with fixes.
+      :privacy_file_aggregation_enabled => podfile_properties['apple.privacyManifestAggregationEnabled'] == 'true',
     )
 
     # This is necessary for Xcode 14, because it signs resource bundles by default

packages/expo-build-properties/CHANGELOG.md

@@ -7,6 +7,7 @@
 ### 🎉 New features
 
 - Add `ios.ccacheEnabled` option to enable the C++ compiler cache for iOS builds. ([#28638](https://github.com/expo/expo/pull/28638) by [@byCedric](https://github.com/byCedric))
+- Add `ios.privacyManifestAggregationEnabled` option to enable/disable privacy manifest aggregation. ([#28646](https://github.com/expo/expo/pull/28646) by [@brentvatne](https://github.com/brentvatne)).
 
 ### 🐛 Bug fixes
 

packages/expo-build-properties/src/__tests__/withBuildProperties-test.ts

@@ -157,12 +157,12 @@ describe(withBuildProperties, () => {
     }).rejects.toThrow();
   });
 
-  it('generates the apple.ccache property', async () => {
+  it('generates the apple.ccacheEnabled property', async () => {
     const { modResults: iosModResultsEnabled } = await compileMockModWithResultsAsync(
       {},
       {
         plugin: withBuildProperties,
-        pluginProps: { ios: { ccache: true } },
+        pluginProps: { ios: { ccacheEnabled: true } },
         mod: withPodfileProperties,
         modResults: {},
       }
@@ -171,4 +171,19 @@ describe(withBuildProperties, () => {
       'apple.ccacheEnabled': 'true',
     });
   });
+
+  it('generates the apple.privacyManifestAggregationEnabled property', async () => {
+    const { modResults: iosModResultsEnabled } = await compileMockModWithResultsAsync(
+      {},
+      {
+        plugin: withBuildProperties,
+        pluginProps: { ios: { privacyManifestAggregationEnabled: true } },
+        mod: withPodfileProperties,
+        modResults: {},
+      }
+    );
+    expect(iosModResultsEnabled).toMatchObject({
+      'apple.privacyManifestAggregationEnabled': 'true',
+    });
+  });
 });

packages/expo-build-properties/src/ios.ts

@@ -26,6 +26,11 @@ export const withIosBuildProperties = createBuildPodfilePropsConfigPlugin<Plugin
       propName: 'apple.ccacheEnabled',
       propValueGetter: (config) => (config.ios?.ccacheEnabled ?? false).toString(),
     },
+    {
+      propName: 'apple.privacyManifestAggregationEnabled',
+      propValueGetter: (config) =>
+        (config.ios?.privacyManifestAggregationEnabled ?? false).toString(),
+    },
   ],
   'withIosBuildProperties'
 );

packages/expo-build-properties/src/pluginConfig.ts

@@ -246,6 +246,16 @@ export interface PluginConfigTypeIos {
    * @see https://ccache.dev/
    */
   ccacheEnabled?: boolean;
+
+  /**
+   * Enable aggregation of Privacy Manifests (`PrivacyInfo.xcprivacy`) from
+   * CocoaPods resource bundles. If enabled, the manifests will be merged into a
+   * single file. If not enabled, developers will need to manually aggregate them.
+   *
+   * @see https://docs.expo.dev/guides/apple-privacy/
+   * @see https://developer.apple.com/documentation/bundleresources/privacy_manifest_files
+   */
+  privacyManifestAggregationEnabled?: boolean;
 }
 
 /**
@@ -543,6 +553,7 @@ const schema: JSONSchemaType<PluginConfigType> = {
 
         networkInspector: { type: 'boolean', nullable: true },
         ccacheEnabled: { type: 'boolean', nullable: true },
+        privacyManifestAggregationEnabled: { type: 'boolean', nullable: true },
 
         extraPods: {
           type: 'array',

templates/expo-template-bare-minimum/ios/Podfile

@@ -33,6 +33,9 @@ target 'HelloWorld' do
       config[:reactNativePath],
       :mac_catalyst_enabled => false,
       :ccache_enabled => podfile_properties['apple.ccacheEnabled'] == 'true'
+      # Temporarily disable privacy file aggregation by default, until React
+      # Native 0.74.2 is released with fixes.
+      :privacy_file_aggregation_enabled => podfile_properties['apple.privacyManifestAggregationEnabled'] == 'true',
     )
 
     # This is necessary for Xcode 14, because it signs resource bundles by default