Fix minimize-on-close for TB 52 on Linux #179
Conversation
This commit uses the close event handler in addition to existing code, in order to properly suppress the window close event if closed through the window manager. I'm unsure how the mechanism was intended to work, so I left existing code in place although I assume that the existing window close handler could get removed now.
|
Hi, |
|
@undera I don't have a full mozilla build environment set up, so my builds emit localization warnings and most likely cause various issues when run on a locale whose translation is not complete. If still want a build: mintrayr-1.3.2+tb52fix.xpi.zip (unzip once to get the XPI to install, GitHub does not permit XPI attachments). |
|
Just as a tip - you can create a release on GitHub from your repo and it will allow XPI to be attached there. The original repo seems to be abandoned, I guess many people would enjoy your improvements. |
|
I installed it, but it does not help. My issue is that I see no tray icon at all. I see in processes that thunderbird is still running, so the "hiding" part works fine, just no tray icon appears. |
|
@undera did it work with the previous version (when minimizing to tray through the menu)? I did not change anything in the actual minimization code, only fixed the trigger for Thunderbird. What OS are you on? Version of Thunderbird? Are there messages in the error console? Edit: Oh, and just in case: what locale are you on? |
|
Just checked with the stock version - no tray icon.
Andrey Pokhilko
…On 08/03/2017 05:38 PM, rsjtdrjgfuzkfg wrote:
@undera <https://github.com/undera> did it work with the previous
version (when minimizing to tray through the menu)? I did not change
anything in the actual minimization code, only fixed the trigger for
Thunderbird.
What OS are you on? Version of Thunderbird? Are there messages in the
error console?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#179 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB7r5YrjD8nx8MMVJCEpq7hZ1yk9U9UOks5sUdtugaJpZM4OkOTh>.
|
|
@rsjtdrjgfuzkfg your fixed build indeed works for me. I'm on Ubuntu with Unity where there is a permanent tray icon present even without the extension, so not facing the same problem as @undera. |
|
Works for me, using gentoo and thunderbird 52.2.0. Thank you very much! |
|
Doesn't work on thunderbird 52.2.1, gnome 3.24.3, fedora 26. |
|
Works for me, using Debian 9.1 (x86-64) and Thunderbird 52.2.1 (64-bits), Cinnamon 3.2.7. |
|
Works for me, thank you very much! Ubuntu 16.04.3, GNOME Shell 3.18.5, Thunderbird 52.2.1. |
|
@nmaier What's the status on this? |
|
Works for me on arch with GNOME 3.24.2 and TB 52.3.0. Great job @rsjtdrjgfuzkfg 👍 |
|
Works with FC 26, TB 52.3.0 |
|
This fixed the closing to tray issue, but now is not minimizing to tray. Linux Mint 18.1 Cinnamon 64 bits |
|
Fixed, XFCE on Ubuntu 16.04 |
|
It's working for me - both close and minimise cause Thunderbird to sit in the tray! Thunderbird 52.4.0 (64-bit) Thanks for tracking this down and submitting a fix! |
|
It mostly works for me (52.4.0 64-bit, Linux Mint 17.3). Notes: It still minimizes to taskbar if I click the minimize button, and I have to enable "always show tray icon" otherwise it vanishes when I close. But if I enable that, then it stays in the tray only. Edit: I was also running "Minimize on start and close" and this was interfering, I think it was overriding mintrayr's minimize to tray on close, so it was just minimizing (to taskbar) instead of closing. When I disabled start-and-close, then mintrayr minimizes to tray on close button, without having to have it always showing. Interesting that with "always show tray" turned OFF and "minimize on start and close" turned ON, the close button would appear to completely close the app, as if ignoring both add-ons. I wonder if each add-on is using some kind of toggle to change a value so they're cancelling each other out? Neither extension seems able to properly minimise to tray with the minimize button. |
|
The fix it's working for me too, both closing and minimizing to tray. Thunderbird 52.5.0 (64-bit) |
|
It seems to be fixed.
…On Jan 1, 2018 10:20 AM, "Matteo Martelli" ***@***.***> wrote:
The fix it's working for me too, both closing and minimizing to tray.
Thunderbird 52.5.0 (64-bit)
Linux mint 18.3 mate
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#179 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF2tvuQ3a0JJOdNE-iqcrkjrcUSsXB7eks5tGPefgaJpZM4OkOTh>
.
|
|
Aqui também esta funcionando Ubuntu 17.10 Thunderbird 52 Obrigado |
This incorporates rsjtdrjgfuzkfg's fixes in nmaier/mintrayr#179
This PR attempts to fix #178, #175 and #172 – but is untested on Windows and old versions of Thunderbird. I'd welcome some feedback on that, as I don't have the time to do proper testing right now.
I consider it very likely that we don't need to observe
titlebar-closeanymore after merging this. It does not callgoQuitApplicationbutwindow.close– at least in the versions of TB I looked at, but I'm not comfortable doing the removal without any tests on Windows.Also, the maintainer might want to use a different version number after merging; I merely added something in order to distinguish built xpis from official releases.