Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all enum cases in switch #890

Closed
wants to merge 3 commits into from

Conversation

shamprasadps
Copy link

@shamprasadps shamprasadps commented Dec 22, 2017

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]


Pull request checklist

Test suite compiles and runs without any error.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.8 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

src/json.hpp Outdated
@@ -6564,7 +6578,7 @@ class serializer
// check that the additional bytes are present
assert(i + bytes < s.size());

// to use \uxxxx escaping, we first need to calculate
// to use \uxxxx escaping, we first need to caluclate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo introduced here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the typo .
a9e1cbb

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a9e1cbb on shamprasadps:develop into 88ddb12 on nlohmann:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 99.966% when pulling faa24a8 on shamprasadps:develop into 88ddb12 on nlohmann:develop.

@nlohmann
Copy link
Owner

As described in #889: I do not like the idea add redundancies to the code to make GCC happy while adding a Clang warning at the same time. See #555 for a discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants