add to_json method for C arrays #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlohmann
reviewed
Mar 16, 2017
src/json.hpp.re2c
Outdated
| @@ -800,6 +800,11 @@ void to_json(BasicJsonType& j, const CompatibleObjectType& arr) | |||
| external_constructor<value_t::object>::construct(j, arr); | |||
| } | |||
|
|
|||
| template <typename BasicJsonType, typename T, std::size_t N, enable_if_t<not std::is_constructible<typename BasicJsonType::string_t, T(&)[N]>::value, int> = 0> | |||
| void to_json(BasicJsonType &j, T (&tab)[N]) { | |||
There was a problem hiding this comment.
We could exploit the knowledge of the size and call a reserve on the internal vector before.
There was a problem hiding this comment.
Indeed, I shall add an overload to external_constructor
theodelrieu
force-pushed
the
feature/c_array_conversion
branch
from
47f2db0 to
8ef0498
Compare
gregmarr
reviewed
Mar 16, 2017
src/json.hpp.re2c
Outdated
| @@ -536,6 +536,19 @@ struct external_constructor<value_t::array> | |||
| } | |||
| j.assert_invariant(); | |||
| } | |||
|
|
|||
| template<typename BasicJsonType, typename T, std::size_t N> | |||
| static void construct(BasicJsonType& j, T (&arr)[N]) | |||
There was a problem hiding this comment.
Can we not use the same implementation as line 523? std::begin and std::end work just fine on built-in arrays.
If the array can be converted to basic_json::string_t, the overload in this commit is not chosen.
theodelrieu
force-pushed
the
feature/c_array_conversion
branch
from
8ef0498 to
dbebf8d
Compare
|
Indeed, I've been sloppy since this morning, good catch |
|
Thanks a lot!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this commit intends to fix #502.
I don't think there is a way to initialize a C-array from a json object, hence the only
to_jsonoverload in this commit.