Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in operator[] documentation #3102

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix typos in operator[] documentation #3102

merged 2 commits into from
Oct 20, 2021

Conversation

axnsan12
Copy link
Contributor

@axnsan12 axnsan12 commented Oct 20, 2021 •
edited
Loading

Was reading the docs and this doesn't really make sense 😄

@request-info

This comment has been minimized.

Sign in to view
@request-info request-info bot added the state: needs more info the author of the issue needs to provide more details label Oct 20, 2021
@coveralls
Copy link

coveralls commented Oct 20, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0721b32 on axnsan12:patch-3 into 67c8ead on nlohmann:develop.

nlohmann
nlohmann approved these changes Oct 20, 2021
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added documentation release item: 🔨 further change and removed state: needs more info the author of the issue needs to provide more details labels Oct 20, 2021
@nlohmann nlohmann added this to the Release 3.10.5 milestone Oct 20, 2021
@nlohmann nlohmann merged commit f5b3fb3 into nlohmann:develop Oct 20, 2021
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
documentation release item: 🔨 further change
Projects
None yet
Milestone
Release 3.10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@axnsan12 @coveralls @nlohmann