-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC 10 tests build failure #1920
Comments
The problem here is that
With Args={const json&}. The GCC 10 improved the detection of incomplete types usage in this commit: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=271806 I think this ticket deserves the maintainer attention because it will lead to compilation issues on user side of the library when they compile their code with GCC10. |
Any idea how to fix this? |
Thing is, this variadic perfect-forwarding ctor is matching copy/move ctor. |
I was wrong, that's mutual recursion cycle. Will try to figure something out. |
…types Templatize basic_json constructor from json_ref
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded.
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]>
nlohmann required some changes for gcc10. Those changes have not been officially released yet by the project. The following issues has details on the bug: nlohmann/json#1920 Change-Id: I853f36f961fcd094a3f399028182c308a970c2e5 Signed-off-by: Andrew Geissler <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Change-Id: I92f641bf4859708fbf78d78448e16c39577a2e39 Signed-off-by: Andrew Geissler <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]> (cherry picked from commit 12b707c) Signed-off-by: Armin Kuster <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]> (cherry picked from commit 12b707c) Signed-off-by: Armin Kuster <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]>
The following issue and PR describe an issue with nlohmann-json and GCC10. nlohmann/json#1920 nlohmann/json#2034 Confirmed that this fixed the issue seen in OpenBMC when pulling in the latest upstream meta-openembedded. Signed-off-by: Khem Raj <[email protected]>
Unit tests build failure.
Build using GCC 10.0.
Successful build.
Build failure:
GCC 10.0.1 from Fedora 32.
develop
branch?Latest release.
The text was updated successfully, but these errors were encountered: