Unable to compile on MSVC 2015 with SDL checking enabled: This function or variable may be unsafe.

[dmartyn-0]

When this library is compiled under MSVC 2015 with SDL checking on, compilation fails with this error:

C4996 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.

The error occurs here at line 4694:

edit: This occurs with the latest release available from the releases list.

[whackashoe]

snprintf could work. Otherwise, to disable you could do:

#ifdef _MSC_VER
#define _CRT_SECURE_NO_WARNINGS
#endif

[whackashoe]

From a bit of reading looks like snprintf is a bit variable between os... might it be useful to just skip sprintf altogether and do it manually?

[whackashoe]

heh - i messed up trying to rewrite a character ^^

@nlohmann can you take a look at this and if you're ok with it I can do a pull request, think its perhaps less shitty than alternatives. we can also probably take out include on cstdio but not positive on that.

[nlohmann]

Hi @whackashoe, thanks for looking into the issue. I would love to see a pull request with your replacement!

[Stateford]

https://github.com/nlohmann/json/blob/develop/single_include/nlohmann/json.hpp#L7658

I'm running into this issue again. Looks like there's another call to snprintf here.

Looks like it was added 7.25.2020