Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commented out test cases, should they be removed? #1060

Closed
whackashoe opened this issue Apr 19, 2018 · 2 comments
Closed

Commented out test cases, should they be removed? #1060

whackashoe opened this issue Apr 19, 2018 · 2 comments
Assignees
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone

Comments

@whackashoe
Copy link
Contributor

I found a few files with commented out test cases, wondering if they should be kept or banished to git history


test/src/unit-allocator.cpp

test/src/unit-cbor.cpp

test/src/unit-regression.cpp

test/src/unit-ubjson.cpp

test/src/unit-class_lexer.cpp

test/src/unit-regression.cpp

@nlohmann
Copy link
Owner

You are right - there are several commented-out test cases. I need to check for the individual reasons for those. I think in the case for the binary formats, it is just laziness from my side, because I copied the test file from CBOR, made some adjustments, and commented-out all tests that could not be adjusted.

@nlohmann nlohmann self-assigned this Apr 22, 2018
@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Apr 22, 2018
@nlohmann nlohmann added this to the Release 3.1.3 milestone Apr 22, 2018
@nlohmann
Copy link
Owner

I had a look at the test cases and adjusted them. Thanks for noting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

No branches or pull requests

2 participants