Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added copy constructor. #3

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Added copy constructor. #3

merged 1 commit into from
Nov 2, 2017

Conversation

jetsfandb
Copy link

Fixes issue #810 in the json project.
When json objects are copied the m_map contents are not being copied.

nlohmann
nlohmann approved these changes Nov 2, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Nov 2, 2017
@nlohmann nlohmann merged commit dca42fb into nlohmann:master Nov 2, 2017
@nlohmann
Copy link
Owner

nlohmann commented Nov 2, 2017

Thanks!

@nlohmann nlohmann mentioned this pull request Nov 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jetsfandb @nlohmann @dmbrenn-lirr